Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingress: Add Ingress to v1 API and update backend to defaultBackend #89778

Merged
merged 1 commit into from Jun 17, 2020
Merged

ingress: Add Ingress to v1 API and update backend to defaultBackend #89778

merged 1 commit into from Jun 17, 2020

Conversation

cmluciano
Copy link

@cmluciano cmluciano commented Apr 2, 2020 •
edited by liggitt

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR adds Ingress to the networking v1 APIs. The planned rename of backend to defaultBackend is also implemented.

Which issue(s) this PR fixes:
xref:

Special notes for your reviewer:

  • Add v1 API
  • Renamed backend to defaultBackend

Does this PR introduce a user-facing change?:

`Ingress` and `IngressClass` resources have graduated to `networking.k8s.io/v1`. Ingress and IngressClass types in the `extensions/v1beta1` and `networking.k8s.io/v1beta1` API versions are deprecated and will no longer be served in 1.22+. Persisted objects can be accessed via the `networking.k8s.io/v1` API. Notable changes in v1 Ingress objects (v1beta1 field names are unchanged):
* `spec.backend` -> `spec.defaultBackend`
* `serviceName` -> `service.name`
* `servicePort` -> `service.port.name` (for string values)
* `servicePort` -> `service.port.number` (for numeric values)
* `pathType` no longer has a default value in v1; "Exact", "Prefix", or "ImplementationSpecific" must be specified
Other Ingress API updates:
* backends can now be resource or service backends
* `path` is no longer required to be a valid regular expression

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Ingress KEP

kubernetes/enhancements#1453

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 2, 2020
@cmluciano
Copy link
Author

cmluciano commented Apr 2, 2020 •
edited

/cc @robscott @liggitt

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 2, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@fedebongio
Copy link
Contributor

/assign @liggitt
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 2, 2020
@cmluciano
Copy link
Author

/retest

1 similar comment
@cmluciano
Copy link
Author

/retest

@cmluciano
Copy link
Author

/assign @robscott

robscott
robscott reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this! Will be great to get this in early in the release cycle.

pkg/apis/networking/types.go Outdated Show resolved Hide resolved
pkg/apis/networking/types.go Outdated Show resolved Hide resolved
pkg/apis/networking/types.go Show resolved Hide resolved
pkg/apis/networking/v1beta1/BUILD Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
@liggitt liggitt added this to In progress in API Reviews Apr 7, 2020
@liggitt liggitt added the api-review Categorizes an issue or PR as actively needing an API review. label Apr 7, 2020
liggitt
liggitt reviewed Apr 7, 2020
View reviewed changes
api/api-rules/violation_exceptions.list Outdated Show resolved Hide resolved
pkg/apis/networking/validation/validation.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Show resolved Hide resolved
@liggitt liggitt moved this from In progress to Changes requested in API Reviews Apr 7, 2020
@liggitt liggitt added this to the v1.19 milestone Apr 7, 2020
rfranzke added a commit to gardener/gardener that referenced this pull request Aug 28, 2020
@rfranzke
Update API versions for 1.19
90d6bdd 
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this pull request Aug 31, 2020
@rfranzke
Update API versions for 1.19
ed22135 
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this pull request Aug 31, 2020
@rfranzke
Update API versions for 1.19
042d208 
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this pull request Sep 1, 2020
@rfranzke
Update API versions for 1.19
023d91e 
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this pull request Sep 1, 2020
@rfranzke
Update API versions for 1.19
a284d73 
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
@youssefazrak youssefazrak mentioned this pull request Oct 21, 2020
Merged
This was referenced Nov 1, 2020
Closed
Open
@VGerris VGerris mentioned this pull request Jan 18, 2021
Closed
ezeeyahoo pushed a commit to ezeeyahoo/gardener that referenced this pull request Feb 20, 2021
@rfranzke @ezeeyahoo
Update API versions for 1.19
59ff173 
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
This was referenced Mar 4, 2021
Merged
Merged
@taishin taishin mentioned this pull request Mar 12, 2021
Merged
1 task
tendant added a commit to tendant/simple-app that referenced this pull request Jun 7, 2021
@tendant
update serviceName, after upgrading to kubernetes 1.19
eca6a7d 
kubernetes/kubernetes#89778
@sschne sschne mentioned this pull request Jun 27, 2021
Merged
valorl added a commit to valorl/deprek8ion that referenced this pull request Jul 23, 2021
@valorl
Add networking.k8s.io/v1beta1 ingress policy
8123396 
In addition to `extensions/v1beta1`, `networking.k8s.io/v1beta1` was
also deprecated in 1.19 and is also targeted for removal in 1.22.

Deprecation PR: kubernetes/kubernetes#89778
Removal mention in deprecation guide: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122
@valorl valorl mentioned this pull request Jul 23, 2021
Merged
@GusAntoniassi GusAntoniassi mentioned this pull request Jul 26, 2021
Closed
@hescmi hescmi mentioned this pull request Sep 29, 2021
Closed
@atsikham atsikham mentioned this pull request Oct 12, 2021
Merged
e11d added a commit to e11d/mastodon that referenced this pull request Jan 2, 2022
@e11d
Kubernetes v1.19 対応
e040914 
k8s.io/v1beta1 → k8s.io/v1

https://stackoverflow.com/questions/64125048/get-error-unknown-field-servicename-in-io-k8s-api-networking-v1-ingressbacken
kubernetes/kubernetes#89778
fredlahde added a commit to fredlahde/helm-charts that referenced this pull request Feb 25, 2022
@fredlahde
Update Ingress Resource for k8s 21
147eba5 
This commit implements the changes introduces in [1] and  documented in
[2]

Mainly, this concerns the definiton of a `backend` and the necessity to
declare a `pathType`[3].

I choose `ImplementationSpecific` here, as this was the default
previously and passes the decision how the path should be matched to our
`nignx-ingress`.

[1] kubernetes/kubernetes#89778
[2] https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/
[3] https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#better-path-matching-with-path-types
@fredlahde fredlahde mentioned this pull request Feb 25, 2022
Merged
@skrthomas skrthomas mentioned this pull request Feb 28, 2022
Closed
@chivalryq chivalryq mentioned this pull request Oct 21, 2022
Merged
4 tasks
@LizBaldo LizBaldo mentioned this pull request Feb 3, 2023
Merged
@nikodemas nikodemas mentioned this pull request May 15, 2023
Merged
@veidenberg veidenberg mentioned this pull request Jul 13, 2023
Closed
@hsubramanianaks hsubramanianaks mentioned this pull request Sep 11, 2023
Merged
@joeyAghion joeyAghion mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@liggitt liggitt liggitt left review comments

@apelisse apelisse apelisse left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@davidopp davidopp Awaiting requested review from davidopp

Assignees

@robscott robscott

@liggitt liggitt

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.19
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@cmluciano @fejta-bot @fedebongio @liggitt @robscott @k8s-ci-robot @apelisse