-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote HugePageStorageMediumSize feature to Beta #90592
Promote HugePageStorageMediumSize feature to Beta #90592
Conversation
/assign @liggitt |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/retest |
routing to node reviewers |
/assign @derekwaynecarr |
lgtm, once we will merge e2e tests #91243 we can merge this one. |
I agree that this is ready to promote once #91243 merges, it will need a doc update similar to kubernetes/website#19008 |
@derekwaynecarr thank you for the review. Documentation update has been submitted: kubernetes/website#21528 |
/retest |
/test pull-kubernetes-e2e-gce-ubuntu-containerd |
/retest |
/approve |
/lgtm |
e2df933
to
1540557
Compare
@derekwaynecarr I had to rebase this due to a conflict with master. Please lgtm again. |
e2e failures are unrelated to change. /retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bart0sh, derekwaynecarr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig node |
/retest |
1 similar comment
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This change promotes HugePageStorageMediumSize feature to Beta and enables support for multiple size huge pages by default.
Does this PR introduce a user-facing change?: