Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the users of IsQualifiedName to ValidateQualifiedName #99828

Closed
XudongLiuHarold opened this issue Mar 5, 2021 · 17 comments · Fixed by #102074 or #108150
Closed

Change the users of IsQualifiedName to ValidateQualifiedName #99828

XudongLiuHarold opened this issue Mar 5, 2021 · 17 comments · Fixed by #102074 or #108150
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/usability Categorizes an issue or PR as relevant to SIG Usability.

Comments

@XudongLiuHarold
Copy link
Member

After #98277 got merged, we have added new helper function ValidateQualifiedName here: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation.go#L126.

It will be good for us to use this simpler helper function to replace previous IsQualifiedName function.

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@XudongLiuHarold:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

After #98277 got merged, we have added new helper function ValidateQualifiedName here: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation.go#L126.

It will be good for us to use this simpler helper function to replace previous IsQualifiedName function.

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

@XudongLiuHarold: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@XudongLiuHarold
Copy link
Member Author

/sig usability

@k8s-ci-robot k8s-ci-robot added sig/usability Categorizes an issue or PR as relevant to SIG Usability. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 5, 2021
@mowangdk
Copy link
Contributor

mowangdk commented Mar 5, 2021

I would like to take this one
/assign

@creydr
Copy link
Contributor

creydr commented May 19, 2021

@mowangdk I worked in #102074 on this as well, but kept your changed files untouched (as written in my PR description). @greenapple10: same for you.
I hope this is OK for you.

@creydr
Copy link
Contributor

creydr commented May 25, 2021

This should be reopened until #99883 and #100903 got merged (my PR #102074 excluded the changes from the other PRs).

@aojea
Copy link
Member

aojea commented Oct 6, 2021

This should be reopened until #99883 and #100903 got merged (my PR #102074 excluded the changes from the other PRs).

/reopen
per last comment

@k8s-ci-robot
Copy link
Contributor

@aojea: Reopened this issue.

In response to this:

This should be reopened until #99883 and #100903 got merged (my PR #102074 excluded the changes from the other PRs).

/reopen
per last comment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Oct 6, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2022
@manavsiddharthgupta
Copy link

can you assign me

@XudongLiuHarold
Copy link
Member Author

/assign @manavsiddharthgupta

@nishant-siddh
Copy link

/assign

@nishant-siddh nishant-siddh removed their assignment Feb 5, 2022
@mangoGoForward
Copy link
Contributor

I'd love to work on this issue.
/assign

@mangoGoForward
Copy link
Contributor

Hi, @XudongLiuHarold , I am a first commitor for kubernetes and I have committed a PR in #108150, could you help me to review it, or give me some suggestions. Thanks a lot.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 30, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/usability Categorizes an issue or PR as relevant to SIG Usability.
Projects
None yet
9 participants