Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark v1beta1 EndpointSlice deprecated in favor of v1 #100472

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Mark v1beta1 EndpointSlice deprecated in favor of v1 #100472

merged 1 commit into from
Mar 23, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 23, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Marks v1beta1 EndpointSlices deprecated in favor of v1.

Leaves removal version at 1.25, so the only change is that users get an extra release of notifications to use v1.

Does this PR introduce a user-facing change?

discovery.k8s.io/v1beta1 EndpointSlices are deprecated in favor of discovery.k8s.io/v1, and will no longer be served in Kubernetes v1.25.

/cc @swetharepakula @robscott

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Mar 23, 2021
@liggitt
Copy link
Member Author

liggitt commented Mar 23, 2021

Noticed this wasn't done when the topology deprecation question came up in kubernetes/website#27032 (comment)

@liggitt
Copy link
Member Author

liggitt commented Mar 23, 2021

This should be paired with a docs PR adding v1beta1 EndpointSlice to https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25 and enumerating the field-by-field deltas to v1 EndpointSlices

@swetharepakula
Copy link
Member

Kubeproxy hasn't switched to using the v1 API. I think we need to wait for that before deprecating v1beta1.

@liggitt
Copy link
Member Author

liggitt commented Mar 23, 2021 •
edited
Loading

Kubeproxy hasn't switched to using the v1 API. I think we need to wait for that before deprecating v1beta1.

Marking as deprecated doesn't remove the API, it just notifices of removal in a future release. Since we know the 1.25 removal release and there's a replacement clients can switch to in 1.21, giving more advance notice to those clients seems like a good idea to me.

@liggitt
Copy link
Member Author

liggitt commented Mar 23, 2021

/sig network
/kind cleanup

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 23, 2021
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@swetharepakula
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2021
@liggitt
Copy link
Member Author

liggitt commented Mar 23, 2021

/retest

@liggitt
Copy link
Member Author

liggitt commented Mar 23, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 23, 2021
@liggitt
Copy link
Member Author

liggitt commented Mar 23, 2021

/milestone v1.21

needed to ensure consistent surfacing of promoted APIs in 1.21 as replacements for existing beta versions

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 23, 2021
@swetharepakula swetharepakula mentioned this pull request Mar 23, 2021
Merged
@swetharepakula
Copy link
Member

The doc changes will be covered in kubernetes/website#27070

@k8s-ci-robot k8s-ci-robot merged commit 16610bb into kubernetes:master Mar 23, 2021
@liggitt liggitt deleted the endpoint-slice-v1beta1 branch March 29, 2021 19:58
@github-actions github-actions bot mentioned this pull request Apr 5, 2021
Open
@jaredjenkins
Copy link

Any details on if EndpointSlices server APIs will be compatible for the server 1.19 and below? It's unclear how this kind of deprecation will impact folks who are on an older version of the server but want to use the new client.

@aojea
Copy link
Member

aojea commented May 12, 2022

I don't fully understand the question, but these are the deprecation policy rules for the APIs https://kubernetes.io/docs/reference/using-api/deprecation-policy/ , maybe that can answer your question

@jaredjenkins
Copy link

Sorry if I was unclear. The question was specifically trying to understand if we should expect the latest version of client APIs to be compatible with servers that only provide the beta version of the API.

AFAICT, server < v1.21 supports only the beta endpoint slices API.

I am trying to figure out if we can use the latest version of the client libraries with the beta server.

@jaredjenkins
Copy link

looking over that doc that you shared, it sounds like yes but at some point support the beta server will get dropped from client API. does that sound correct?

@jaredjenkins
Copy link

So the answer is no and that is really unfortunate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott Awaiting requested review from robscott

@swetharepakula swetharepakula Awaiting requested review from swetharepakula

Assignees

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @k8s-ci-robot @swetharepakula @fejta-bot @jaredjenkins @aojea