Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote graceful shutdown based on pod priority to beta #107986

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Promote graceful shutdown based on pod priority to beta #107986

merged 6 commits into from
Mar 23, 2022

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Feb 7, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref kubernetes/enhancements#3194

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote graceful shutdown based on pod priority to beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2712-pod-priority-based-graceful-node-shutdown/README.md

/cc @mrunalp
/cc @bobbypage

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2022
@wzshiming wzshiming force-pushed the promote/shutdown-based-on-pod-priority branch 2 times, most recently from fd0d6d3 to 5245075 Compare February 7, 2022 14:14
@ehashman
Copy link
Member

/assign @dgrisonnet
for instrumentation

@ehashman
Copy link
Member

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 10, 2022
dgrisonnet
dgrisonnet reviewed Feb 10, 2022
View reviewed changes
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
@wzshiming wzshiming force-pushed the promote/shutdown-based-on-pod-priority branch from 5245075 to 457cfff Compare February 11, 2022 02:47
@wzshiming
Copy link
Member Author

/test pull-kubernetes-node-kubelet-serial
/test pull-kubernetes-node-kubelet-serial-containerd

@wzshiming wzshiming force-pushed the promote/shutdown-based-on-pod-priority branch 2 times, most recently from 23c5441 to 000d3fe Compare February 11, 2022 03:10
@wzshiming
Copy link
Member Author

/retest

@endocrimes
Copy link
Member

/test pull-kubernetes-node-kubelet-serial-containerd

@bobbypage
Copy link
Member

Thanks for the additions, lgtm from my side

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@wzshiming
Copy link
Member Author

/retest

mrunalp
mrunalp reviewed Mar 17, 2022
View reviewed changes
pkg/kubelet/nodeshutdown/nodeshutdown_manager_linux.go
sta := state{}
err := m.storage.Load(&sta)
if err != nil {
klog.ErrorS(err, "Failed to load graceful shutdown state")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This should be a warning

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structured logs have only Error and Info. Is it to modify the message content to change it from Failed to Warning?

@wzshiming
Copy link
Member Author

/assign @derekwaynecarr

@mrunalp
Copy link
Contributor

mrunalp commented Mar 22, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2022
@ehashman ehashman mentioned this pull request Mar 22, 2022
Closed
4 tasks
ehashman
ehashman reviewed Mar 22, 2022
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beta criteria:

  • Addresses feedback from alpha testers
  • Sufficient E2E and unit testing

I think this is all covered and confirmed by reviewers.

Thanks!

/approve
for pkg/features

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, mrunalp, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@rphillips
Copy link
Member

/retest-required

@wzshiming
Copy link
Member Author

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit a6e65a2 into kubernetes:master Mar 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 23, 2022
@wzshiming wzshiming deleted the promote/shutdown-based-on-pod-priority branch March 24, 2022 04:30
@bobbypage bobbypage mentioned this pull request Mar 24, 2022
Merged
@ehashman ehashman mentioned this pull request Mar 28, 2022
Closed
@mrunalp mrunalp mentioned this pull request Apr 6, 2022
Merged
@tengqm tengqm mentioned this pull request Apr 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes left review comments

@ehashman ehashman ehashman left review comments

@dgrisonnet dgrisonnet dgrisonnet left review comments

@mrunalp mrunalp mrunalp approved these changes

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees

@mrunalp mrunalp

@bobbypage bobbypage

@derekwaynecarr derekwaynecarr

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
10 participants
@wzshiming @ehashman @bobbypage @endocrimes @k8s-ci-robot @mrunalp @rphillips @k8s-triage-robot @dgrisonnet @derekwaynecarr