Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention CephFS and RBD in-tree storage driver deprecation #42201

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jul 25, 2023

Ceph RBD driver is in deprecation path :

kubernetes/kubernetes#118552

CephFS driver is in deprecation path:

kubernetes/kubernetes#118143

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jul 25, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 25, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 25, 2023
@netlify
Copy link

netlify bot commented Jul 25, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 24d8bd5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64ce435bbd0ae20008524220

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2023
@humblec
Copy link
Contributor Author

humblec commented Jul 25, 2023

/assign @xing-yang

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8cc2c3cd8673a432396adeb027201279c693a55a

@sftim
Copy link
Contributor

sftim commented Jul 25, 2023

/retitle Mention CephFS and RBD in-tree storage driver deprecation

@k8s-ci-robot k8s-ci-robot changed the title mention CephFS and RBD in-tree storage driver deprecation. Mention CephFS and RBD in-tree storage driver deprecation Jul 25, 2023
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2023
@humblec humblec force-pushed the dev-1.28 branch 2 times, most recently from 79c43f6 to 79b18e4 Compare July 25, 2023 12:49
Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, try these changes. vSphere is different because it is out of tree; the other two are better described as “third party”.

@@ -375,7 +375,7 @@ the following types of volumes:
* {{< glossary_tooltip text="csi" term_id="csi" >}}
* flexVolume (deprecated)
* gcePersistentDisk
* rbd
* rbd ( **deprecated** in v1.28)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* rbd ( **deprecated** in v1.28)
* rbd (deprecated)

Comment on lines +731 to 737
* `cephfs` ( **deprecated** in v1.28)
* `cinder` (**deprecated** in v1.18)
* `gcePersistentDisk`
* `iscsi`
* `nfs`
* `rbd`
* `rbd` ( **deprecated** in v1.28)
* `vsphereVolume`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `cephfs` ( **deprecated** in v1.28)
* `cinder` (**deprecated** in v1.18)
* `gcePersistentDisk`
* `iscsi`
* `nfs`
* `rbd`
* `rbd` ( **deprecated** in v1.28)
* `vsphereVolume`
* `cephfs` (deprecated)
* `cinder` (deprecated)
* `gcePersistentDisk`
* `iscsi`
* `nfs`
* `rbd` (deprecated)
* `vsphereVolume`

content/en/docs/concepts/storage/persistent-volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Jul 25, 2023

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jul 25, 2023
Match how existing lists are doing it
Use different language for out-of-project and in-project alternatives
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 93b775563538dc28c801020c68551497f4170f1b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit b73d9b8 into kubernetes:dev-1.28 Aug 5, 2023
1 of 2 checks passed
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
Mention CephFS and RBD in-tree storage driver deprecation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants