Graduate DevicePluginCDIDevices to Beta

[bart0sh]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR graduates DevicePluginCDIDevices to Beta in 1.29

Special notes for your reviewer:

KEP update PR has been already merged: kubernetes/enhancements#4238

Does this PR introduce a user-facing change?

DevicePluginCDIDevices feature has been graduated to Beta and enabled by default in the Kubelet

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[Documentation update PR]: https://github.com/kubernetes/website/pull/43435

[pacoxu]

According to https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4009-add-cdi-devices-to-device-plugin-api/README.md#graduation-criteria,

Alpha

Add the CDIDevices field to the device plugin API
Implement the logic to pass the CDIDevices into the CRI
Add proper e2e_node tests

Alpha to Beta Graduation

No major bugs reported in the previous cycle

better to wait for #119280.

@elezar are you still working adding e2e test for CDI devices? This sounds like a bar for alpha.(Probably, this can be the beta promotion criteria IMO).

loop in KEP reviewers and approver:
/cc @swatisehgal @kklues
/assign @mrunalp

[pacoxu]

/sig node
/priority important-soon

[swatisehgal]

/triage accepted

[swatisehgal]

better to wait for #119280.

@elezar are you still working adding e2e test for CDI devices? This sounds like a bar for alpha.(Probably, this can be the beta promotion criteria IMO).

I tend to agree, addition of the e2e tests should be Beta promotion criteria. We should make sure that #119280 (once ready and reviewed) is merged before this PR.

[bart0sh]

@pacoxu @swatisehgal Thanks for pointing out to #119280. I'll work on adding e2e tests.

btw, should it be a pre-submit or periodic test or both?

[bart0sh]

/retest

[swatisehgal]

@pacoxu @swatisehgal Thanks for pointing out to #119280. I'll work on adding e2e tests.

btw, should it be a pre-submit or periodic test or both?

I think it would be good for us to have both as periodic jobs help us track the health of the jobs on a regular basis and pre-submit jobs helps us prevent regressions when new PRs are submitted. This could be a good topic for discussion in the SIG Node CI subgroup and give a heads-up that we'd be introducing new jobs for testing of this feature.

[bart0sh]

@swatisehgal @ffromani @klueska @mrunalp I've added test case for this feature in #121440. It would be great if we can merge this PR. This would allow us to remove skipping the test if feature gate is not enabled and labelling the test as AlphaFeature in #121440.

[klueska]

/lgtm
/approve

/hold
For #121440

/assign @dims
For final feature-gate approval

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: ce0d30cd64d48ef011079110495671fc7587f2d9

[dims]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, dims, klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/features/OWNERS [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[klueska]

/unhold