Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device Plugins: add an info about beta graduation #43435

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Device Plugins: add an info about beta graduation #43435

merged 1 commit into from
Nov 22, 2023

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Oct 11, 2023

No description provided.

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 25615ec
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/653a510424b98b00081ad738

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@bart0sh bart0sh mentioned this pull request Oct 11, 2023
Open
12 tasks
elezar
elezar approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@elezar
Copy link
Contributor

elezar commented Oct 11, 2023

/remove-lgtm

Let's address @windsonsea's comments first.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@bart0sh
Copy link
Contributor Author

bart0sh commented Oct 11, 2023

@windsonsea @elezar Thank you for the review! All suggestions have been merged into the PR branch. PTAL.

@sftim
Copy link
Contributor

sftim commented Oct 11, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 11, 2023
elezar
elezar approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fdb8b3630aafcee2086bdae477dd3c302a04e0c6

@bart0sh
Copy link
Contributor Author

bart0sh commented Oct 11, 2023

/assign @SergeyKanzhelev @mrunalp @derekwaynecarr @dchen1107
for SIG-Node approval

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@bart0sh
Copy link
Contributor Author

bart0sh commented Oct 16, 2023

@pacoxu thank you for the review. Code change PR has been created as suggested: kubernetes/kubernetes#121254, PTAL.

@derekwaynecarr
Copy link
Member

Just noting that the related PR is blocking promotion to beta pending additional e2e tests.

@bart0sh bart0sh mentioned this pull request Oct 23, 2023
Merged
@klueska
Copy link
Contributor

klueska commented Oct 25, 2023 •
edited
Loading

/approve
For sig-node

/hold
For kubernetes/kubernetes#121440

@bart0sh
Copy link
Contributor Author

bart0sh commented Oct 26, 2023

/unhold
as kubernetes/kubernetes#121440 and kubernetes/kubernetes#121254 have been merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2023
@bart0sh
Copy link
Contributor Author

bart0sh commented Oct 26, 2023

@mrunalp @SergeyKanzhelev can you review / approve?

@bart0sh @windsonsea @klueska
Device Plugins: add info about beta graduation
25615ec 
Co-authored-by: Michael <haifeng.yao@daocloud.io>
Co-authored-by: Kevin Klues <klueska@gmail.com>
@bart0sh bart0sh force-pushed the PR029-Add-CDI-devices-to-device-plugin-API branch from 7df578c to 25615ec Compare October 26, 2023 11:43
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 82ad6c897f90117cb9c75f840079fbd2bf9b91af

@pacoxu
Copy link
Member

pacoxu commented Oct 30, 2023

/assign @SergeyKanzhelev @mrunalp @derekwaynecarr @dchen1107 for SIG-Node approval

/lgtm
/assign @reylejano

@windsonsea
Copy link
Member

/lgtm

@Princesso
Copy link
Contributor

/lgtm

@Princesso
Copy link
Contributor

Hello @bart0sh 👋, gentle reminder to get your PR merged before the deadline, Tuesday 28th November 2023. Thank you!

@Princesso
Copy link
Contributor

/assign @reylejano

sftim
sftim reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elezar, klueska, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit dc15c69 into kubernetes:dev-1.29 Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windsonsea windsonsea windsonsea left review comments

@sftim sftim sftim left review comments

@klueska klueska klueska left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@onlydole onlydole Awaiting requested review from onlydole

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@elezar elezar Awaiting requested review from elezar

@mrunalp mrunalp Awaiting requested review from mrunalp

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@mrunalp mrunalp

@elezar elezar

@pacoxu pacoxu

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

@Princesso Princesso

@reylejano reylejano

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
1.29
Development

Successfully merging this pull request may close these issues.