-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up etcd dependency to fix data race #24022
Conversation
/cc @wojtek-t @timothysc @xiang90 This is prereq to the watcher implementation. |
GCE e2e build/test passed for commit df41d88abcae75608997e0f40b14012ecc70dbaf. |
GCE e2e build/test passed for commit 71b46f3. |
Looks like the tests are green, but just so I'm clear this change to the server looks to affect both clients? and is this an officially released version of etcd? We typically only bump the dep on sanctioned releases. |
This is not. Hongchao is working on v3 so he was tracking the master. |
k, then we should either close this pull or mark as WIP to revisit at a later date. |
The v2 client change just remove the outdated code because we are not using go1.4 anymore. The changes to v2 client include:
|
@timothysc |
I don't care that much about the client as long as it works. This doesn't change the version of etcd that we run, which I do care about. However it also changes the version of etcd that we build for kube2sky (?maybe? @ArtfulCoder). However we're going to stop doing that in the near future anyway. I guess my only concern would be if this causes our tests to test something that is not the same as what we run against in production. |
I want to point out that we ensure it is as close to production env as possible by using real etcd binaries in testing, i.e. e2e and integration testing, not the imported version for unit testing. etcd also runs a bunch of CI to ensure API behavior doesn't change, including regression, of both v2 and v3. |
GCE e2e build/test passed for commit 71b46f3. |
GCE e2e build/test passed for commit 71b46f3. |
GCE e2e build/test passed for commit 71b46f3. |
/cc @k8s-oncall Can we get this merged? |
GCE e2e build/test passed for commit 71b46f3. |
Something seems have changed in godep licenses. Updated |
Can you help re-add 'lgtm' label? |
GCE e2e build/test passed for commit 66bd277db6a78129862977be2fe14a63da20645d. |
GCE e2e build/test passed for commit 66bd277db6a78129862977be2fe14a63da20645d. |
GCE e2e build/test passed for commit 3c2c906. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 3c2c906. |
Automatic merge from submit-queue |
Bug 1719686: Fix ceph expansion Origin-commit: 0b8be0c706c82dd106af405702bde33fbc7a6e7c
ref: #23694
What this PR does