Bump up etcd dependency to fix data race

[hongchaodeng]

ref: #23694

What this PR does

• Bumping up the godep of etcd to fix data race in etcd watcher. Without this change, watcher PR builds will fail in race detection.
• Small changes to fix builds after upgrade

[hongchaodeng]

/cc @wojtek-t @timothysc @xiang90

This is prereq to the watcher implementation.
It also provides the API of event types as requested by Tim.

[k8s-bot]

GCE e2e build/test passed for commit df41d88abcae75608997e0f40b14012ecc70dbaf.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit 71b46f3.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[timothysc]

Looks like the tests are green, but just so I'm clear this change to the server looks to affect both clients? and is this an officially released version of etcd?

We typically only bump the dep on sanctioned releases.

[xiang90]

and is this an officially released version of etcd?

This is not. Hongchao is working on v3 so he was tracking the master.

[timothysc]

k, then we should either close this pull or mark as WIP to revisit at a later date.

[hongchaodeng]

The v2 client change just remove the outdated code because we are not using go1.4 anymore.

The changes to v2 client include:

• etcd-io/etcd@25e47db : It removes some go1.4 only code
• etcd-io/etcd@6e6d64f : It cleans up unused variables.
• Some docs update

[hongchaodeng]

@timothysc
I think the changes on v2 client are pretty minor, actually good for go1.6. Do you still have any concern I can help answer?

[timothysc]

@lavalamp @wojtek-t ping on policy here?
Do we want to allow godep from non-released versions?

[lavalamp]

I don't care that much about the client as long as it works. This doesn't change the version of etcd that we run, which I do care about. However it also changes the version of etcd that we build for kube2sky (?maybe? @ArtfulCoder). However we're going to stop doing that in the near future anyway.

I guess my only concern would be if this causes our tests to test something that is not the same as what we run against in production.

[hongchaodeng]

I want to point out that we ensure it is as close to production env as possible by using real etcd binaries in testing, i.e. e2e and integration testing, not the imported version for unit testing.

etcd also runs a bunch of CI to ensure API behavior doesn't change, including regression, of both v2 and v3.

[k8s-bot]

GCE e2e build/test passed for commit 71b46f3.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit 71b46f3.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit 71b46f3.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[xiang90]

/cc @k8s-oncall Can we get this merged?

[k8s-bot]

GCE e2e build/test passed for commit 71b46f3.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[hongchaodeng]

Something seems have changed in godep licenses. Updated

[hongchaodeng]

Can you help re-add 'lgtm' label?
@timothysc @mikedanese @yifan-gu

[k8s-bot]

GCE e2e build/test passed for commit 66bd277db6a78129862977be2fe14a63da20645d.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[hongchaodeng]

@k8s-bot unit test this please github issue: #24298

[k8s-bot]

GCE e2e build/test passed for commit 66bd277db6a78129862977be2fe14a63da20645d.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-bot]

GCE e2e build/test passed for commit 3c2c906.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-github-robot]

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

[k8s-bot]

GCE e2e build/test passed for commit 3c2c906.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[k8s-github-robot]

Automatic merge from submit-queue