Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation][(Un)join-01] Refactor common functions and structs into a util package. #35592

Merged
merged 3 commits into from
Nov 2, 2016
Merged

[Federation][(Un)join-01] Refactor common functions and structs into a util package. #35592

merged 3 commits into from
Nov 2, 2016

Conversation

madhusudancs
Copy link
Contributor

@madhusudancs madhusudancs commented Oct 26, 2016 •
edited
Loading

Please review only the last commit here. This is based on PR #35495 which will be reviewed independently.

Design Doc: PR #34484

cc @kubernetes/sig-cluster-federation @quinton-hoole @nikhiljindal

This change is Reviewable

@madhusudancs madhusudancs added area/cluster-federation release-note-none Denotes a PR that doesn't merit a release note. labels Oct 26, 2016
@madhusudancs madhusudancs added this to the v1.5 milestone Oct 26, 2016
@k8s-github-robot k8s-github-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 26, 2016
@madhusudancs madhusudancs mentioned this pull request Oct 26, 2016
Merged
@ghost
Copy link

ghost commented Oct 27, 2016

LGTM, thanks @madhusudancs

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2016
@ghost ghost self-assigned this Oct 27, 2016
@ghost
Copy link

ghost commented Oct 27, 2016

@madhusudancs PS you have some verification and unit test failures to resolve before merging.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2016
k8s-github-robot pushed a commit that referenced this pull request Oct 29, 2016
Merge pull request #35593 from madhusudancs/federation-kubefed-init-c…
962a152 
…ertutil-triple

Automatic merge from submit-queue

Implement package `triple` with utilities to generate certificate-key pairs for CA, server and clients.

Please review only the last commit here. This is based on PRs #35592 which will be reviewed independently.

Design Doc: PR #34484

cc @kubernetes/sig-cluster-federation @quinton-hoole @mwielgus
@madhusudancs
[Federation][unjoin-00] Implement kubefed unjoin command.
90d46c8 
Also, add unit tests for `kubefed unjoin`.
@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2016
@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 419fc9de7eb4f89c478d684a9786e18f31b9b769. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 419fc9de7eb4f89c478d684a9786e18f31b9b769. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit fe36da1e38917c4de7997f39db4bed074f4293d7. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit fe36da1e38917c4de7997f39db4bed074f4293d7. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit fe36da1e38917c4de7997f39db4bed074f4293d7. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 963a6ad82f94198d618ca6faccb04a71fa3d1497. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs
[Federation] Implement the kubefed command.
3c692eb 
Also:
1. Add it to the client build targets list.
2. Register `kubefed join` and `kubefed unjoin` commands.
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit c044cae. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@madhusudancs
Copy link
Contributor Author

Adding retest-not-required label because it only touches federation.

@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9a7ad2e into kubernetes:master Nov 2, 2016
@madhusudancs madhusudancs deleted the federation-kubefed-04 branch November 2, 2016 21:58
@madhusudancs madhusudancs mentioned this pull request Nov 17, 2016
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mwielgus mwielgus

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@madhusudancs @k8s-ci-robot @k8s-github-robot @googlebot @mwielgus