Implement package triple with utilities to generate certificate-key pairs for CA, server and clients.
#35593
Conversation
madhusudancs
added
area/cluster-federation
release-note-none
k8s-github-robot
added
the
size/XXL
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ |
There was a problem hiding this comment.
Add comment here explaining what is this package for. It is not obvious what a package named "triple" will do :)
There was a problem hiding this comment.
Added the package doc.
| limitations under the License. | ||
| */ | ||
|
|
||
| package triple |
There was a problem hiding this comment.
How about keypairgenerator as package name?
There was a problem hiding this comment.
keypairgenerator is too long. Also, that's what the parent package does. This package uses the parent package to generate the keypairs, but generates the pairs for the (CA, server, client) triple.
|
@nikhiljindal addressed the comment. PTAL. |
|
Jenkins unit/integration failed for commit 2a7be55ff258787cefc9d9538d432f6fa28df586. Full PR test history. The magic incantation to run this job again is |
|
Jenkins verification failed for commit 2a7be55ff258787cefc9d9538d432f6fa28df586. Full PR test history. The magic incantation to run this job again is |
|
I still dont like triple but dont have a better suggestion than |
madhusudancs
force-pushed
the
federation-kubefed-init-certutil-triple
branch
from
2a7be55
to
a9544b2
Compare
|
@nikhiljindal leaving it as is. Rebased on top of master and squashed the commits. Applying the LGTM label. |
… pairs for CA, server and clients.
madhusudancs
force-pushed
the
federation-kubefed-init-certutil-triple
branch
from
a9544b2
to
47e53f2
Compare
madhusudancs
added
the
lgtm
k8s-github-robot
added
size/L
|
Jenkins Kubemark GCE e2e failed for commit 47e53f2. Full PR test history. The magic incantation to run this job again is |
|
Jenkins GCI GCE e2e failed for commit 47e53f2. Full PR test history. The magic incantation to run this job again is |
|
@k8s-bot gci gce e2e test this |
|
@k8s-bot kubemark e2e test this |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Automatic merge from submit-queue [Federation][init] Implement `kubefed init` command that performs federation control plane bootstrap. Please review only the last commit here. This is based on PR #35593 which will be reviewed independently. I am intentionally not including the unit tests in this PR to better distribute and parallelize reviews. This PR is already big. I will add a release note separately for this entire feature, so please don't worry too much about the release note here in the PR. Design Doc: PR #34484 cc @kubernetes/sig-cluster-federation @quinton-hoole @nikhiljindal
Please review only the last commit here. This is based on PR #35592 which will be reviewed independently.
Design Doc: PR #34484
cc @kubernetes/sig-cluster-federation @quinton-hoole @mwielgus
This change is