Update verify-openapi-spec script to check for extra generated spec #35841
Conversation
mbohlool
added
the
release-note-none
k8s-github-robot
added
the
size/XXL
| cp -a "${SPECROOT}" "${TMP_SPECROOT}" | ||
| trap "cp -a ${TMP_SPECROOT} \"${KUBE_ROOT}/api\"; rm -rf ${_tmp}" EXIT SIGINT |
There was a problem hiding this comment.
Will cp -a ${TMP_SPECROOT}/* ${SPECROOT} or cp -a ${TMP_SPECROOT} ${SPECROOT}/.. work?
There was a problem hiding this comment.
Yes, it is works and better. I just (blindly) copy/paster the command on (old) line 42. Would use your first suggestion.
|
One comment and adding back the -N, then lgtm. Feel free to self apply the label. |
k8s-github-robot
added
the
needs-rebase
k8s-github-robot
removed
the
needs-rebase
|
Jenkins unit/integration failed for commit af76a70d9ba7107e5fb75e81bf39c033be89c546. Full PR test history. The magic incantation to run this job again is |
k8s-github-robot
added
the
needs-rebase
mbohlool
added
lgtm
|
@k8s-bot node e2e test this issue #ignore |
|
Jenkins GCE Node e2e failed for commit c2f99d2. Full PR test history. The magic incantation to run this job again is |
|
@mbohlool Dont you need to make the same change in verify-federation-openapi-spec? |
|
ok I see, we dont have verify-federation-openapi-spec, only update-federation-openapi-spec :) |
|
yep, we should add federation verify script but let me add it in another PR. This PR get rebased often because people edit v1.json spec file. |
|
oh yes, dont need to block this PR :) |
|
Automatic merge from submit-queue |
hack/verify-openapi-spec.sh only check for existing spec changes. If for some reason (here most probably I forgot to delete a file in api/openapi-spec folder in #35388 after a rebase) there is an old spec exists in the spec folder, it won't panic but it should. This resulted in an unused out of date v1.spec file in the api/openapi-spec folder that this PR also removes.
This change is