Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointed to community/contributors/guide/README.md (Partially fixes kubernetes/community#1413) #57226

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Pointed to community/contributors/guide/README.md (Partially fixes kubernetes/community#1413) #57226

merged 1 commit into from
Dec 18, 2017

Conversation

anubhakushwaha
Copy link
Contributor

@anubhakushwaha anubhakushwaha commented Dec 15, 2017 •
edited by spiffxp
Loading

What this PR does / why we need it:
This PR helps in the documentation for contributor's guideline by adding the link to community/contributors/guide/README.md in kubernetes/kubernetes/contributing.md

Which issue(s) this PR fixes
Partially fix for kubernetes/community#1413 (edit by @spiffxp to remove the "fixes" keyword)

@k8s-ci-robot k8s-ci-robot added retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2017
@anubhakushwaha
Copy link
Contributor Author

/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added the sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. label Dec 15, 2017
@nikhita
Copy link
Member

nikhita commented Dec 15, 2017

/release-note-none
/ok-to-test

@anubhakushwaha Congratulations on making your first PR! 🎉

Can you update the PR title to something like Partial fix for kubernetes/community#1413 instead of Fixes kubernetes/community#1413. The umbrella issue would be closed when this PR would get merged (there are still other points that need to be completed as well).

/cc @parispittman @guineveresaenger

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 15, 2017
@k8s-ci-robot k8s-ci-robot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2017
@k8s-ci-robot
Copy link
Contributor

@nikhita: GitHub didn't allow me to request PR reviews from the following users: guineveresaenger.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/release-note-none
/ok-to-test

@anubhakushwaha Congratulations on making your first PR! 🎉

Can you update the PR title to something like Partial fix for kubernetes/community#1413 instead of Fixes kubernetes/community#1413. The umbrella issue would be closed when this PR would get merged (there are still other points that need to be completed as well).

/cc @parispittman @guineveresaenger

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita
Copy link
Member

nikhita commented Dec 15, 2017

/retest

@anubhakushwaha anubhakushwaha changed the title Pointed to community/contributors/guide/README.md Pointed to community/contributors/guide/README.md (Partially fixes kubernetes/community#1413) Dec 15, 2017
@anubhakushwaha
Copy link
Contributor Author

@nikhita Thanks a lot for checking the PR. Is the title better now?

guineveresaenger
guineveresaenger reviewed Dec 15, 2017
View reviewed changes
CONTRIBUTING.md Outdated
@@ -2,7 +2,7 @@

Information about contributing to the
[kubernetes code repo](README.md) lives in the
[kubernetes community repo](https://github.com/kubernetes/community)
[kubernetes community repo](https://git.k8s.io/community/contributors/guide/)
(it's a big topic).
Copy link
Contributor

@guineveresaenger guineveresaenger Dec 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're redoing the contributor guide, we can afford to be a bit more definite here. As well, explaining about joining the community and linking to k/community, e.g:

Welcome to Kubernetes! If you are interested in contributing to the code repo then check out the Contributor
Guide

The Kubernetes community repo
contains information on how the community is organized and other information
that is pertinent to contributing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guineveresaenger Thanks a lot for reviewing the PR, I did the changes :)

@guineveresaenger
Copy link
Contributor

Hi @anubhakushwaha ! Thank you for helping with this. See my comment above. :)

@guineveresaenger guineveresaenger mentioned this pull request Dec 15, 2017
Closed
@anubhakushwaha
Copy link
Contributor Author

@guineveresaenger Please review.

guineveresaenger
guineveresaenger approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Waiting for a full member to approve...
@castrojo @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Dec 15, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2017
@anubhakushwaha
Copy link
Contributor Author

@brendandburns Please have a look, thank you :)

@guineveresaenger
Copy link
Contributor

guineveresaenger commented Dec 18, 2017 •
edited
Loading

@anubhakushwaha I hear this step can take a while on k/kubernetes repo, and it's also the holidays. (I'm out for a week myself starting tomorrow). If someone hasn't caught it by the time I'm back, I'll poke people in Slack about it. :)

@anubhakushwaha
Copy link
Contributor Author

@guineveresaenger Ooh that sounds awesome, thanks a lot :)

@brendandburns
Copy link
Contributor

/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubhakushwaha, brendandburns, spiffxp

Associated issue: #1413

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2017
@brendandburns brendandburns added this to the v1.10 milestone Dec 18, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5d10139 into kubernetes:master Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guineveresaenger guineveresaenger guineveresaenger approved these changes

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@spiffxp spiffxp

@smarterclayton smarterclayton

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
8 participants
@anubhakushwaha @nikhita @k8s-ci-robot @guineveresaenger @spiffxp @brendandburns @k8s-github-robot @smarterclayton