New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using go1.9.3 #59012

Merged
merged 2 commits into from Jan 30, 2018

Conversation

Projects
None yet
5 participants
@ixdy
Member

ixdy commented Jan 30, 2018

What this PR does / why we need it: more minor bugfixes, which I guess we probably want. https://github.com/golang/go/issues?q=milestone%3AGo1.9.3

Special notes for your reviewer: I haven't built/pushed the crossbuild image yet, but will do so if we think this is a good idea. I don't have plans to rebuild the test images.

Release note:

Build using go1.9.3.

Who are good people to review this?
/assign @cblecker @luxas
(for lack of better ideas)

ixdy added some commits Jan 30, 2018

@cblecker

This comment has been minimized.

Member

cblecker commented Jan 30, 2018

@ixdy Looks good to me (pending image push)

@cblecker

This comment has been minimized.

Member

cblecker commented Jan 30, 2018

(and this should be picked back to 1.9)

@ixdy

This comment has been minimized.

Member

ixdy commented Jan 30, 2018

crossbuild image pushed.

/retest

@cblecker

This comment has been minimized.

Member

cblecker commented Jan 30, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 30, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jan 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 30, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Jan 30, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 783790a into kubernetes:master Jan 30, 2018

12 of 13 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation ixdy authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-unit Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@ixdy

This comment has been minimized.

Member

ixdy commented Feb 7, 2018

cherrypick PR: #59498

@cblecker

This comment has been minimized.

Member

cblecker commented Feb 7, 2018

@ixdy go1.9.4 is coming out today with a security fix. we should probably pause for that before cherry pick.

@ixdy

This comment has been minimized.

Member

ixdy commented Feb 7, 2018

good call.

k8s-merge-robot added a commit that referenced this pull request Mar 3, 2018

Merge pull request #59498 from ixdy/automated-cherry-pick-of-#59012-u…
…pstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #59012

Cherry pick of #59012 on release-1.9.

#59012: Update to go1.9.3

@ixdy ixdy deleted the ixdy:update-to-go1.9.3 branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment