New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated code should pass go vet for go1.10 #62412

Merged
merged 3 commits into from Apr 20, 2018

Conversation

@bhcleek
Contributor

bhcleek commented Apr 11, 2018

What this PR does / why we need it:

Update code generator and the code it generates to pass go vet.

go1.10 runs go vet whenever go test is run. Because of this, generated code for CRDs needs to pass go vet.

Release note:

Code generated for CRDs now passes `go vet`.
@bhcleek

This comment has been minimized.

Contributor

bhcleek commented Apr 11, 2018

/sig api-machinery
/area custom-resources

@cblecker

This comment has been minimized.

Member

cblecker commented Apr 11, 2018

/ok-to-test
/cc @sttts

@k8s-ci-robot k8s-ci-robot requested a review from sttts Apr 11, 2018

@sttts

This comment has been minimized.

Contributor

sttts commented Apr 12, 2018

lgtm when it's green
/approve

@cblecker

This comment has been minimized.

Member

cblecker commented Apr 12, 2018

/retest

@wenjiaswe

This comment has been minimized.

Contributor

wenjiaswe commented Apr 12, 2018

@roycaihw

This comment has been minimized.

Member

roycaihw commented Apr 16, 2018

Please run make update to regenerate the code for other packages as well.

   M pkg/client/clientset_generated/internalclientset/fake/clientset_generated.go
   M staging/src/k8s.io/apiextensions-apiserver/examples/client-go/pkg/client/clientset/versioned/fake/clientset_generated.go
   M staging/src/k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/fake/clientset_generated.go
   M staging/src/k8s.io/apiextensions-apiserver/pkg/client/clientset/internalclientset/fake/clientset_generated.go
   M staging/src/k8s.io/client-go/kubernetes/fake/clientset_generated.go
   M staging/src/k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset/fake/clientset_generated.go
   M staging/src/k8s.io/kube-aggregator/pkg/client/clientset_generated/internalclientset/fake/clientset_generated.go
   M staging/src/k8s.io/metrics/pkg/client/clientset_generated/clientset/fake/clientset_generated.go
   M staging/src/k8s.io/sample-apiserver/pkg/client/clientset/internalversion/fake/clientset_generated.go
   M staging/src/k8s.io/sample-apiserver/pkg/client/clientset/versioned/fake/clientset_generated.go
   M staging/src/k8s.io/sample-controller/pkg/client/clientset/versioned/fake/clientset_generated.go

lgtm when tests are green

@roycaihw

This comment has been minimized.

Member

roycaihw commented Apr 16, 2018

/assign

@bhcleek

This comment has been minimized.

Contributor

bhcleek commented Apr 16, 2018

/retest

@cblecker

This comment has been minimized.

Member

cblecker commented Apr 17, 2018

/test pull-kubernetes-bazel-test

@bhcleek

This comment has been minimized.

Contributor

bhcleek commented Apr 17, 2018

The bazel test failures are valid. I'm working on fixing them now.

@roycaihw

This comment has been minimized.

Member

roycaihw commented Apr 17, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 17, 2018

@sttts

This comment has been minimized.

Contributor

sttts commented Apr 18, 2018

/assign @deads2k
/assign @DirectXMan12

for approval.

@deads2k

This comment has been minimized.

Contributor

deads2k commented Apr 18, 2018

/approve
/hold

holding to squash all that generated code into one "generated" commit.

bhcleek added some commits Apr 11, 2018

generate code that passes go vet
* Make sure sync.RWMutex values aren't copied.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 18, 2018

@bhcleek

This comment has been minimized.

Contributor

bhcleek commented Apr 18, 2018

I rebased to reduce the number of commits; all regenerated fakes are now in a single commit.

@bhcleek

This comment has been minimized.

Contributor

bhcleek commented Apr 18, 2018

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@deads2k

This comment has been minimized.

Contributor

deads2k commented Apr 20, 2018

/approve
/hold cancel

@deads2k

This comment has been minimized.

Contributor

deads2k commented Apr 20, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 20, 2018

@deads2k deads2k added the approved label Apr 20, 2018

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Apr 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: bhcleek, deads2k, roycaihw, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k

This comment has been minimized.

Contributor

deads2k commented Apr 20, 2018

it's just the generated expression in metrics. tagging.

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 20, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-merge-robot

This comment has been minimized.

Contributor

k8s-merge-robot commented Apr 20, 2018

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-merge-robot k8s-merge-robot merged commit 5dde701 into kubernetes:master Apr 20, 2018

15 of 16 checks passed

Submit Queue Required Github CI test is not green: pull-kubernetes-e2e-gce
Details
cla/linuxfoundation bhcleek authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

@bhcleek bhcleek deleted the bhcleek:go1.10 branch Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment