Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move pkg/scheduler/schedulercache -> pkg/scheduler/cache #63839

Merged
merged 1 commit into from
Jun 1, 2018
Merged

Move pkg/scheduler/schedulercache -> pkg/scheduler/cache #63839

merged 1 commit into from
Jun 1, 2018

Conversation

wgliang
Copy link
Contributor

@wgliang wgliang commented May 15, 2018 •
edited
Loading

What this PR does / why we need it:
Move pkg/scheduler/schedulercache -> pkg/scheduler/cache

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #63813

Special notes for your reviewer:

In order to prevent name conflicts still rename the cache to schedulercache.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels May 15, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 15, 2018
@wgliang
Copy link
Contributor Author

wgliang commented May 15, 2018

/kind cleanup
/sig scheduling

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 15, 2018
@wgliang wgliang force-pushed the master.movepkg branch 2 times, most recently from 0bf4c69 to 63ce456 Compare May 15, 2018 03:35
@wgliang
Copy link
Contributor Author

wgliang commented May 15, 2018

/test pull-kubernetes-verify

@wgliang wgliang changed the title [WIP] Move pkg/scheduler/schedulercache -> pkg/scheduler/cache Move pkg/scheduler/schedulercache -> pkg/scheduler/cache May 15, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2018
@wgliang
Copy link
Contributor Author

wgliang commented May 15, 2018

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-local-e2e-containerized

@idealhack
Copy link
Member

/cc @derekwaynecarr @tallclair @vishh @yujuhong
still needs more approving review

@dchen1107
Copy link
Member

lgtm on kubelet side.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2018
@cblecker
Copy link
Member

needs rebase

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2018
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 31, 2018
@wgliang
Copy link
Contributor Author

wgliang commented May 31, 2018

@cblecker
Rebase done.PTAL

@cblecker
Copy link
Member

/test pull-kubernetes-e2e-gce

@cblecker
Copy link
Member

/skip

@kubernetes kubernetes deleted a comment from k8s-ci-robot May 31, 2018
@wgliang
Copy link
Contributor Author

wgliang commented May 31, 2018

/skip

@idealhack
Copy link
Member

idealhack commented Jun 1, 2018 •
edited
Loading

So we are waiting for lgtm label and a milestone. /cc @cblecker

@bsalamat bsalamat added this to the v1.11 milestone Jun 1, 2018
@bsalamat bsalamat added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed milestone/incomplete-labels labels Jun 1, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@bsalamat @dashpole @misterikkit @smarterclayton @wgliang

Pull Request Labels
  • sig/cluster-lifecycle sig/node sig/scheduling: Pull Request will be escalated to these SIGs if needed.
  • priority/important-longterm: Escalate to the pull request owners; move out of the milestone after 1 attempt.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

bsalamat
bsalamat approved these changes Jun 1, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

re-applying the label

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, dashpole, dchen1107, liggitt, mikedanese, misterikkit, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63348, 63839, 63143, 64447, 64567). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 5710943 into kubernetes:master Jun 1, 2018
misterikkit pushed a commit to misterikkit/kubernetes that referenced this pull request Aug 21, 2018
Add misterikkit to sig-scheduling REVIEWERS.
2df71c7 
I have met the following criteria.
- member for at least 3 months
- primary reviewer for at least 5 PRs
  - kubernetes#63603
  - kubernetes#63665 (and related PRs)
  - kubernetes#63839
  - kubernetes#65714
  - kubernetes#66862
- reviewed or merged at least 20 PRs
  reviewed 13: https://github.com/pulls?utf8=%E2%9C%93&q=is%3Apr+archived%3Afalse+is%3Amerged+repo%3Akubernetes%2Fkubernetes+commenter%3Amisterikkit+in%3Acomment+assignee%3Amisterikkit+
  merged 22: https://github.com/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Amisterikkit+archived%3Afalse+is%3Amerged+repo%3Akubernetes%2Fkubernetes+
@misterikkit misterikkit mentioned this pull request Aug 21, 2018
Merged
k8s-github-robot pushed a commit that referenced this pull request Aug 22, 2018
Merge pull request #67681 from misterikkit/reviewer
d38fb2c 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add misterikkit to sig-scheduling REVIEWERS.

I have met the following criteria.
- member for at least 3 months
- primary reviewer for at least 5 PRs
  - #63603
  - #63665 (and related PRs)
  - #63839
  - #65714
  - #66862
- reviewed or merged at least 20 PRs
  reviewed 13: https://github.com/pulls?utf8=%E2%9C%93&q=is%3Apr+archived%3Afalse+is%3Amerged+repo%3Akubernetes%2Fkubernetes+commenter%3Amisterikkit+in%3Acomment+assignee%3Amisterikkit+
  merged 22: https://github.com/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Amisterikkit+archived%3Afalse+is%3Amerged+repo%3Akubernetes%2Fkubernetes+


**Release note**:
```release-note
NONE
```
/cc @bsalamat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterikkit misterikkit misterikkit approved these changes

@yastij yastij yastij approved these changes

@bsalamat bsalamat bsalamat approved these changes

@davidopp davidopp Awaiting requested review from davidopp

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@mikedanese mikedanese Awaiting requested review from mikedanese

@ncdc ncdc Awaiting requested review from ncdc

@sjpotter sjpotter Awaiting requested review from sjpotter

@soltysh soltysh Awaiting requested review from soltysh

@sttts sttts Awaiting requested review from sttts

@thockin thockin Awaiting requested review from thockin

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@smarterclayton smarterclayton

@misterikkit misterikkit

@dashpole dashpole

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Move pkg/scheduler/schedulercache -> pkg/scheduler/cache