Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block volume support to Cinder volume plugin #64879

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
6 participants
@bertinatto
Copy link
Member

bertinatto commented Jun 7, 2018

What this PR does / why we need it:

This PR adds block volume support to Cinder volume plugin.

Release note:

Added block volume support to Cinder volume plugin.
@wgliang

This comment has been minimized.

Copy link
Member

wgliang commented Jun 7, 2018

/ok-to-test

@bertinatto

This comment has been minimized.

Copy link
Member Author

bertinatto commented Jun 7, 2018

/test pull-kubernetes-node-e2e

@bertinatto

This comment has been minimized.

Copy link
Member Author

bertinatto commented Jun 8, 2018

/assign @jsafrane

@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Jun 8, 2018

/sig storage

if len(vID) <= 1 {
return nil, fmt.Errorf("failed to get volumeID from global path=%s", globalMapPath)
}
if !strings.Contains(vID, "vol-") {

This comment has been minimized.

@jsafrane

jsafrane Jun 8, 2018

Member

Please double check that Cinder volume have really vol- prefix in their IDs. OpenStack GUI show me that there is no specific prefix.

return nil, fmt.Errorf("failed to get volumeID from global path=%s, invalid volumeID format = %s", globalMapPath, vID)
}
block := v1.PersistentVolumeBlock
awsVolume := &v1.PersistentVolume{

This comment has been minimized.

@jsafrane

jsafrane Jun 8, 2018

Member

awsVolume in Cinder code?

}

// GetPodDeviceMapPath returns pod device map path and volume name
// path: pods/{podUid}/volumeDevices/kubernetes.io~aws

This comment has been minimized.

@jsafrane

jsafrane Jun 8, 2018

Member

aws?

@bertinatto bertinatto force-pushed the bertinatto:cinder_block branch from c351ed8 to 0c0d2cf Jun 8, 2018

@jsafrane
Copy link
Member

jsafrane left a comment

Almost LGTM, see one nit below.

Please squash your commits, we want code + test + bazel in one commit unless it's really big one.

@@ -88401,5 +88401,5 @@
{
"BearerToken": []
}
]

This comment has been minimized.

@jsafrane

jsafrane Jun 8, 2018

Member

Where this comes from?

@bertinatto bertinatto force-pushed the bertinatto:cinder_block branch from 0c0d2cf to 1f78582 Jun 8, 2018

@bertinatto

This comment has been minimized.

Copy link
Member Author

bertinatto commented Jun 8, 2018

/hold

@bertinatto bertinatto force-pushed the bertinatto:cinder_block branch 3 times, most recently from 6908dd7 to eab2d1e Jun 8, 2018

@bertinatto

This comment has been minimized.

Copy link
Member Author

bertinatto commented Jun 8, 2018

/hold cancel

@bertinatto bertinatto force-pushed the bertinatto:cinder_block branch from eab2d1e to d03b043 Jun 8, 2018

@jsafrane

This comment has been minimized.

Copy link
Member

jsafrane commented Jun 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 8, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 8, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jun 13, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

k8s-github-robot commented Jun 21, 2018

Automatic merge from submit-queue (batch tested with PRs 65256, 64236, 64919, 64879, 57932). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f9ec17d into kubernetes:master Jun 21, 2018

18 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation bertinatto authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details

tengqm added a commit to tengqm/website that referenced this pull request Jun 21, 2018

@bertinatto bertinatto referenced this pull request Oct 1, 2018

Closed

REQUEST: New membership for bertinatto #125

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.