-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix inconsistent behavior of running kube-proxy on 1.12 #66830
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Huang-Wei If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig cluster-lifecycle |
/ok-to-test |
but it becomes a question if we want to enable it by default in kubeadm in 1.12. /assign @luxas |
/hold @neolit123 we're evaluating if it's better to give a fix so as to keep the behavior consistent |
@@ -108,7 +108,16 @@ spec: | |||
- key: CriticalAddonsOnly | |||
operator: Exists | |||
- operator: Exists | |||
nodeSelector: | |||
beta.kubernetes.io/arch: {{ .Arch }} | |||
affinity: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timothysc sorry for the late /hold
label - we're internally evaluating changes to keep the behavior consistent. Most probably we will go that way, and then we don't need this change and will close this pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timothysc as @Huang-Wei said already, we probably won't need this change. We will fix the code on the DS controller side so that the old configuration keeps working.
BTW, inter-pod affinity is expensive. Node affinity which is used here is not that expensive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And long term we're hoping we can completely ditch this so we can just use manifest lists.
cc @dims @neolit123 @mkumatag
Current kube-proxy manifest will continue to work due to #66953. /close |
What this PR does / why we need it:
As feature
ScheduleDaemonSetPods
will be promoted to beta in 1.12, it will result in a "Pending" kube-proxy pod for a fresh kubeadm installation. PS: upgrade case should not be impacted.This PR is to make sure kubeadm behaviors the same in 1.12 on
kube-proxy
daemonset.Which issue(s) this PR fixes:
Fixes part of #66831
Special notes for your reviewer:
Release note: