New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for etcd2 #622

Closed
spiffxp opened this Issue Oct 1, 2018 · 13 comments

Comments

Projects
None yet
9 participants
@spiffxp
Member

spiffxp commented Oct 1, 2018

Feature Description

  • One-line feature description (can be used as a release note): Drop support for etcd2
  • Primary contact (assignee): @spiffxp
  • Responsible SIGs:
    • SIG API Machinery
    • SIG Release
    • SIG Testing
  • Design proposal link (community repo): n/a
  • Link to e2e and/or unit tests: n/a
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    • TBD
  • Approver (likely from SIG/area to which feature belongs):
    • SIG API Machinery: @lavalamp (or whomever they would like to delegate to)
    • SIG Release: @AishSundar (or whomever they would like to delegate to)
    • SIG Testing: @spiffxp
  • Feature target (which target equals to which milestone):
    • Stable release target (1.13)

Context:

I'm filing this as a feature issue to raise visibility, but this is intended to more or less be a turning of the crank that was set in motion last year.

/sig api-machinery
/sig release
/sig testing

@spiffxp

This comment has been minimized.

Member

spiffxp commented Oct 1, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 1, 2018

@spiffxp

This comment has been minimized.

Member

spiffxp commented Oct 1, 2018

/stage stable

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 1, 2018

this has been added to the 1.13 tracking sheet. thanks!

@AishSundar

This comment has been minimized.

AishSundar commented Oct 3, 2018

@spiffxp should we call this /kind feature considering its scope?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Oct 3, 2018

Yep.
/kind feature

@justaugustus

This comment has been minimized.

Member

justaugustus commented Oct 3, 2018

Also, we need a SIG Release owner for this who isn't you, Aish. I think you'll be sufficiently busy with running the release. Maybe @tpepper or @dims ?

@dims

This comment has been minimized.

Member

dims commented Oct 3, 2018

Happy to chip in @justaugustus @AishSundar

@liggitt

This comment has been minimized.

Member

liggitt commented Oct 4, 2018

  • test jobs have been updated
  • kops updated to use etcd3
  • etcd2 support has been removed from the apiserver

@kacole2 kacole2 added the tracked/yes label Oct 8, 2018

@spiffxp

This comment has been minimized.

Member

spiffxp commented Oct 8, 2018

@liggitt @wojtek-t @dims @ixdy @xiang90 following up on kubernetes/kubernetes#69310 (comment)

I think we still have some more etcd2-related code to remove:

./third_party/forked/etcd221
./third_party/forked/etcd237

These are referenced in k/k:

cluster/images/etcd/migrate/rollback_v2.go
28:	oldwal "k8s.io/kubernetes/third_party/forked/etcd221/wal"
30:	// oldwal "k8s.io/kubernetes/third_party/forked/etcd237/wal"

cluster/images/etcd/migrate/BUILD
28:        "//third_party/forked/etcd221/wal:go_default_library",

And I believe we end up publishing

gcr.io/google_containers/etcd-amd64
gcr.io/google_containers/etcd-arm
gcr.io/google_containers/etcd-arm64
gcr.io/google_containers/etcd-ppc64le
gcr.io/google_containers/etcd-s390x
@tfogo

This comment has been minimized.

Member

tfogo commented Nov 3, 2018

Hi @spiffxp! Is there anywhere in the docs we'll need to update due to this?

@AishSundar

This comment has been minimized.

AishSundar commented Nov 12, 2018

@spiffxp do we want to include this in docs? if so can you point us to the PR plz/

@spiffxp

This comment has been minimized.

Member

spiffxp commented Nov 29, 2018

@luxas

This comment has been minimized.

Member

luxas commented Dec 4, 2018

This is now done as v1.13 has been released 👍.

@luxas luxas closed this Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment