Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated --etcd-quorum-read flag #69527

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 8, 2018

What this PR does / why we need it:
Removes the deprecated --etcd-quorum-read flag. This flag was defaulted to true (#53717) and deprecated in 1.9 (#53795).

Setting it to false causes bugs in controllers because of stale reads.

Those bugs can lead to runaway controllers (creating too many objects), stuck controllers (not acting on latest state), and controllers breaking invariants (reacting to objects in different parts of their lifecycle than they are actually in).

Quorum reads performed badly on etcd2, which was the only reason this flag was not removed sooner, but perform well on etcd3. Etcd2 support is dropped in 1.13 in #69310

Special notes for your reviewer:

Release note:

kube-apiserver: the deprecated `--etcd-quorum-read` flag has been removed, and quorum reads are always enabled when fetching data from etcd.

@kubernetes/sig-api-machinery-pr-reviews

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 8, 2018
@liggitt
Copy link
Member Author

liggitt commented Oct 8, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 8, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@deads2k
Copy link
Contributor

deads2k commented Oct 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@liggitt
Copy link
Member Author

liggitt commented Oct 8, 2018

fixed up gofmt for 1.11, fixed up unit test store construction, retagging

@liggitt liggitt added lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 8, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 8, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@liggitt
Copy link
Member Author

liggitt commented Oct 8, 2018

third time's the charm, removed reference from one more unit test

@liggitt liggitt added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 8, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 8, 2018

ref: kubernetes/enhancements#622 for the etcd2 drop

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@spiffxp
Copy link
Member

spiffxp commented Oct 9, 2018

/lgtm cancel
To stop fejta-bot from spamming, this is a failure, not a flake

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Oct 9, 2018

ok, ok. fourth time was the charm. so many unit tests.

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit f9acfd8 into kubernetes:master Oct 9, 2018
@liggitt liggitt deleted the remove-quorum branch October 9, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants