-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated --etcd-quorum-read flag #69527
Conversation
/milestone v1.13 |
/lgtm |
New changes are detected. LGTM label has been removed. |
fixed up gofmt for 1.11, fixed up unit test store construction, retagging |
/retest Review the full test history for this PR. Silence the bot with an |
New changes are detected. LGTM label has been removed. |
third time's the charm, removed reference from one more unit test |
ref: kubernetes/enhancements#622 for the etcd2 drop |
/retest Review the full test history for this PR. Silence the bot with an |
/lgtm cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ok, ok. fourth time was the charm. so many unit tests. |
What this PR does / why we need it:
Removes the deprecated
--etcd-quorum-read
flag. This flag was defaulted to true (#53717) and deprecated in 1.9 (#53795).Setting it to false causes bugs in controllers because of stale reads.
Those bugs can lead to runaway controllers (creating too many objects), stuck controllers (not acting on latest state), and controllers breaking invariants (reacting to objects in different parts of their lifecycle than they are actually in).
Quorum reads performed badly on etcd2, which was the only reason this flag was not removed sooner, but perform well on etcd3. Etcd2 support is dropped in 1.13 in #69310
Special notes for your reviewer:
Release note:
@kubernetes/sig-api-machinery-pr-reviews