Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fsync instead of sync for test #69755

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Use fsync instead of sync for test #69755

merged 1 commit into from
Oct 16, 2018

Conversation

mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Oct 13, 2018

sync sometimes hangs with misbehaving NFS during the tests

cc: @derekwaynecarr @smarterclayton @runcom

Signed-off-by: Mrunal Patel mpatel@redhat.com

What this PR does / why we need it:
This PR switches to using fsync and dd to persist a file for stateful set test instead of touch and sync.
We have seen sync sometimes flake during the tests due to NFS issues.

Fix tests to use fsync instead of sync

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2018
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 13, 2018

/kind cleanup
/retest

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 13, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 13, 2018

/retest

@mrunalp
Use fsync instead of sync for test
6327c74 
sync sometimes hangs with misbehaving NFS during the tests

Signed-off-by: Mrunal Patel <mpatel@redhat.com>
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Oct 15, 2018
@mrunalp
Copy link
Contributor Author

mrunalp commented Oct 15, 2018

/test pull-kubernetes-e2e-gce

@mikedanese
Copy link
Member

@kubernetes/sig-storage-bugs

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/bug Categorizes issue or PR as related to a bug. labels Oct 16, 2018
@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@runcom
Copy link
Contributor

runcom commented Oct 16, 2018

👍

@smarterclayton
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 08be381 into kubernetes:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@jsafrane jsafrane

@saad-ali saad-ali

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mrunalp @spiffxp @mikedanese @jsafrane @runcom @smarterclayton @k8s-ci-robot @saad-ali @msau42