New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD webhook conversion #67006

Merged
merged 4 commits into from Nov 10, 2018

Conversation

@mbohlool
Copy link
Member

mbohlool commented Aug 6, 2018

This PR is ready for review. I plan to bring parts of it (specially the refactoring in first commits) into a new PR. What is intentionally missing from this PR to make it smaller is multi-scheme and multi-print-column etc. support that will be done in a separate PR.

The PR has an end to end test with a nice image that can be used as a reference to implement conversion webhooks (it has separate framework and user code). I will use that for documentation and kubebuilder support.

Add support for CRD conversion webhook

Related PRs and Issues

  • Feature issue
  • #67798: Refactor webhook calling code. Dependency of this PR. Already merged.
  • #67795: The API changes. Going through final API reviews. This PR is rebased on that.
  • #70211 : Multi version schema, additionalprintcolumn and subresources. Not a direct dependency of this PR but related. Current Status: ready to review
  • #70087: Support internal versions for CRDs (fix a bug in /scale). Already merged.

@mbohlool mbohlool self-assigned this Aug 6, 2018

@k8s-ci-robot k8s-ci-robot requested review from erictune and luxas Aug 6, 2018

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch 2 times, most recently from 3f62356 to 0635548 Aug 6, 2018

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch from 0635548 to 4a5cbfb Aug 16, 2018

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch from 4a5cbfb to ef3ac77 Aug 16, 2018

@mbohlool mbohlool changed the title [WIP] CRD webhook conversion CRD webhook conversion Aug 16, 2018

@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Aug 21, 2018

Can you break Refactor addmission webhook hook client to a util package into a separate commit and move it into the client-go library instead of apimachinery? I think I'm gathering that as I move down commits, you'll be re-using this package for the connection from teh apiextensions server.

@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Aug 21, 2018

The types commit appears to match the KEP. Can you break it out into a separate pull to help focus the api-review ?

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch from 90a5fae to 60d5c67 Aug 23, 2018

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch from 104feaf to 5427a77 Nov 9, 2018

mbohlool added some commits Aug 14, 2018

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch from 5427a77 to 655af7c Nov 9, 2018

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch from 655af7c to 3f89267 Nov 9, 2018

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch 3 times, most recently from 4e2f96b to df39d68 Nov 9, 2018

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch from df39d68 to da6fb5f Nov 9, 2018

mbohlool added some commits Nov 1, 2018

@mbohlool mbohlool force-pushed the mbohlool:crd_webhook_conversion branch from da6fb5f to d51d016 Nov 9, 2018

@mbohlool

This comment has been minimized.

Copy link
Member

mbohlool commented Nov 10, 2018

/test pull-kubernetes-e2e-gce-100-performance

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 10, 2018

/lgtm
/approve

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Nov 10, 2018

staging/src/k8s.io/apiextensions-apiserver needs approval by @sttts

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Nov 10, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mbohlool, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 97baad3 into kubernetes:master Nov 10, 2018

18 checks passed

cla/linuxfoundation mbohlool authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment