Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate HugePages feature to GA #72785

Merged
merged 1 commit into from Feb 5, 2019

Conversation

@derekwaynecarr
Copy link
Member

derekwaynecarr commented Jan 10, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Graduates the feature that has been beta for 2 releases.
KEP kubernetes/enhancements#750

Special notes for your reviewer:
Pending sig-node discussion.

Does this PR introduce a user-facing change?:

The HugePages feature gate has graduated to GA, and can no longer be disabled. The feature gate will be removed in v1.16
@derekwaynecarr

This comment has been minimized.

Copy link
Member Author

derekwaynecarr commented Jan 10, 2019

/hold

Show resolved Hide resolved pkg/features/kube_features.go Outdated

@derekwaynecarr derekwaynecarr force-pushed the derekwaynecarr:hugepages-ga branch from 1184940 to 3a80952 Jan 10, 2019

@derekwaynecarr derekwaynecarr force-pushed the derekwaynecarr:hugepages-ga branch from 3a80952 to 8400235 Jan 10, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 11, 2019

lgtm modulo test failure

AppArmor: {Default: true, PreRelease: utilfeature.Beta},
DynamicKubeletConfig: {Default: true, PreRelease: utilfeature.Beta},
AppArmor: {Default: true, PreRelease: utilfeature.Beta},
DynamicKubeletConfig: {Default: true, PreRelease: utilfeature.Beta},

This comment has been minimized.

@liggitt

liggitt Jan 11, 2019

Member

verify gofmt was unhappy with this change, might be your local go version

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 12, 2019

/approve

@derekwaynecarr derekwaynecarr force-pushed the derekwaynecarr:hugepages-ga branch from 8400235 to 2cbbacc Jan 15, 2019

@vishh

This comment has been minimized.

Copy link
Member

vishh commented Jan 15, 2019

/lgtm

@dchen1107

This comment has been minimized.

Copy link
Member

dchen1107 commented Feb 1, 2019

Please resolve the rebase issue; otherwise it is ready to go.

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, derekwaynecarr, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bgrant0607

This comment has been minimized.

Copy link
Member

bgrant0607 commented Feb 2, 2019

/hold cancel

@derekwaynecarr derekwaynecarr force-pushed the derekwaynecarr:hugepages-ga branch from 2cbbacc to deae071 Feb 2, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 5, 2019

/retest
/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 5, 2019

@derekwaynecarr: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized deae071 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit dc1244c into kubernetes:master Feb 5, 2019

15 of 16 checks passed

pull-kubernetes-local-e2e-containerized Job failed.
Details
cla/linuxfoundation derekwaynecarr authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt referenced this pull request Feb 15, 2019

Open

HugePages #751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.