-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix shellcheck pass in sample-apiserver #73210
Conversation
/cc @BenTheElder |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks!
/assign @logicalhan |
@deads2k if you have time, can you help review this? Thanks |
@sttts fixed, PTAL |
d6f4323
to
e2e4373
Compare
/cc @fejta |
|
||
# generate the code with: | ||
# --output-base because this script should also be able to run inside the vendor dir of | ||
# k8s.io/kubernetes. The output-base is needed for the generators to output into the vendor dir | ||
# instead of the $GOPATH directly. For normal projects this can be dropped. | ||
${CODEGEN_PKG}/generate-groups.sh all \ | ||
"${CODEGEN_PKG}"/generate-groups.sh all \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please quote the whole string
"${CODEGEN_PKG}"/generate-groups.sh all \ | |
"${CODEGEN_PKG}/generate-groups.sh" all \ |
|
||
${CODEGEN_PKG}/generate-internal-groups.sh "deepcopy,defaulter,conversion" \ | ||
"${CODEGEN_PKG}"/generate-internal-groups.sh "deepcopy,defaulter,conversion" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too:
"${CODEGEN_PKG}"/generate-internal-groups.sh "deepcopy,defaulter,conversion" \ | |
"${CODEGEN_PKG}/generate-internal-groups.sh" "deepcopy,defaulter,conversion" \ |
--output-base "$(dirname ${BASH_SOURCE})/../../.." \ | ||
--go-header-file ${SCRIPT_ROOT}/hack/boilerplate.go.txt | ||
--output-base "$(dirname "${BASH_SOURCE[0]}")/../../.." \ | ||
--go-header-file "${SCRIPT_ROOT}"/hack/boilerplate.go.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here:
--go-header-file "${SCRIPT_ROOT}"/hack/boilerplate.go.txt | |
--go-header-file "${SCRIPT_ROOT}/hack/boilerplate.go.txt" |
@BenTheElder fixed, thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielqsj, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@danielqsj: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
fix shellcheck failures in
staging/src/k8s.io/sample-apiserver
Which issue(s) this PR fixes:
work towards #72956
Special notes for your reviewer:
Does this PR introduce a user-facing change?: