Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate PriorityClass API to GA #73555

Merged
merged 3 commits into from Feb 23, 2019

Conversation

@bsalamat
Copy link
Contributor

bsalamat commented Jan 31, 2019

What type of PR is this?
/kind api-change

(Not sure if the api-change is the right kind for this PR)

What this PR does / why we need it:
Graduate PriorityClass API to GA.

Which issue(s) this PR fixes:

Fixes #

kubernetes/enhancements#564

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The PriorityClass API has been promoted to `scheduling.k8s.io/v1` with no changes. The `scheduling.k8s.io/v1beta1` version is now deprecated and will stop being served by default in v1.17.
@bsalamat

This comment has been minimized.

Copy link
Contributor Author

bsalamat commented Jan 31, 2019

/assign @k82cn

@bsalamat

This comment has been minimized.

Copy link
Contributor Author

bsalamat commented Jan 31, 2019

/assign @liggitt

@roycaihw

This comment has been minimized.

Copy link
Member

roycaihw commented Jan 31, 2019

/assign @lavalamp

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 5, 2019

I'll take this review. This is a good example of a "promote without changes" API PR, will be good as an example to start a checklist for that type of review.

@bsalamat bsalamat force-pushed the bsalamat:priority_to_ga branch 3 times, most recently from 1038461 to 4af4071 Feb 20, 2019

@liggitt liggitt added the api-review label Feb 21, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 21, 2019

/retest

bsalamat added some commits Feb 20, 2019

@bsalamat bsalamat force-pushed the bsalamat:priority_to_ga branch from 4af4071 to 59da8af Feb 22, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 22, 2019

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 22, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 22, 2019

as a follow-up, please update the API documentation comments on the v1beta1 types to indicate they are deprecated in favor of the v1 versions.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 22, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot merged commit 3afa003 into kubernetes:master Feb 23, 2019

16 checks passed

cla/linuxfoundation bsalamat authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped
tide In merge pool.
Details

@bsalamat bsalamat deleted the bsalamat:priority_to_ga branch Feb 23, 2019

@vreon vreon referenced this pull request Mar 8, 2019

Open

PriorityClass support #2787

rfranzke added a commit to gardener/gardener that referenced this pull request Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.