Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate PriorityClass API to GA #73555

Merged
merged 3 commits into from
Feb 23, 2019
Merged

Graduate PriorityClass API to GA #73555

merged 3 commits into from
Feb 23, 2019

Conversation

bsalamat
Copy link
Member

@bsalamat bsalamat commented Jan 31, 2019 •
edited by liggitt

What type of PR is this?
/kind api-change

(Not sure if the api-change is the right kind for this PR)

What this PR does / why we need it:
Graduate PriorityClass API to GA.

Which issue(s) this PR fixes:

Fixes #

kubernetes/enhancements#564

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The PriorityClass API has been promoted to `scheduling.k8s.io/v1` with no changes. The `scheduling.k8s.io/v1beta1` version is now deprecated and will stop being served by default in v1.17.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 31, 2019
@bsalamat bsalamat added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 31, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 31, 2019
@bsalamat bsalamat force-pushed the priority_to_ga branch 2 times, most recently from 4a5f0aa to 7ece928 Compare January 31, 2019 01:56
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Jan 31, 2019
@bsalamat bsalamat added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 31, 2019
@bsalamat bsalamat mentioned this pull request Jan 31, 2019
Merged
@bsalamat
Copy link
Member Author

/assign @k82cn

@bsalamat
Copy link
Member Author

/assign @liggitt

@roycaihw
Copy link
Member

/assign @lavalamp

@liggitt
Copy link
Member

liggitt commented Feb 5, 2019

I'll take this review. This is a good example of a "promote without changes" API PR, will be good as an example to start a checklist for that type of review.

@liggitt
Copy link
Member

liggitt commented Feb 22, 2019

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2019
@liggitt
Copy link
Member

liggitt commented Feb 22, 2019

as a follow-up, please update the API documentation comments on the v1beta1 types to indicate they are deprecated in favor of the v1 versions.

@liggitt liggitt removed the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Feb 22, 2019
@liggitt liggitt added kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. api-review Categorizes an issue or PR as actively needing an API review. labels Feb 22, 2019
@liggitt liggitt removed this from In progress in API Reviews Feb 22, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@spiffxp spiffxp mentioned this pull request Feb 22, 2019
Closed
@k8s-ci-robot k8s-ci-robot merged commit 3afa003 into kubernetes:master Feb 23, 2019
@bsalamat bsalamat deleted the priority_to_ga branch February 23, 2019 01:19
@bsalamat bsalamat mentioned this pull request Feb 23, 2019
Merged
@vreon vreon mentioned this pull request Mar 8, 2019
Closed
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 20, 2019
@rfranzke
PriorityClass API is promoted to scheduling.k8s.io/v1 with 1.14
94cd93b 
See kubernetes/kubernetes#73555
rfranzke added a commit to gardener/gardener that referenced this pull request Mar 26, 2019
@rfranzke
PriorityClass API is promoted to scheduling.k8s.io/v1 with 1.14
81407bf 
See kubernetes/kubernetes#73555
@mikkeloscar mikkeloscar mentioned this pull request Jul 15, 2019
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@k82cn k82cn k82cn left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bsalamat @roycaihw @liggitt @k8s-ci-robot @fejta-bot @k82cn @lavalamp