Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark PriorityClass v1beta1 and v1alpha1 deprecated by v1 API #74465

Merged
merged 2 commits into from Feb 26, 2019

Conversation

Projects
None yet
4 participants
@bsalamat
Copy link
Contributor

bsalamat commented Feb 23, 2019

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This is a follow-up to #73555 which promoted PriorityClass from Beta to GA (V1).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

PriorityClass in scheduling.k8s.io/v1beta1 and scheduling.k8s.io/v1alpha1 are deprecated by PriorityClass scheduling.k8s.io/v1 and will not be served starting in v1.17.

ref kubernetes/enhancements#564

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 23, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@@ -24,6 +24,7 @@ import (
// +genclient:nonNamespaced
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

// DEPRECATED - This group version of PriorityClass is deprecated by scheduling/v1/PriorityClass.

This comment has been minimized.

@liggitt

liggitt Feb 24, 2019

Member

These are external facing so should use scheduling.k8s.io/v1

This comment has been minimized.

@bsalamat

bsalamat Feb 25, 2019

Author Contributor

Thanks, @liggitt. Done. PTAL.

bsalamat added some commits Feb 23, 2019

@bsalamat bsalamat force-pushed the bsalamat:priority_to_ga branch from b2a959d to 66cf8c8 Feb 25, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 25, 2019

updated the release note with the targeted release for stopping serving the deprecated versions

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 25, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 25, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit c9e14c8 into kubernetes:master Feb 26, 2019

16 checks passed

cla/linuxfoundation bsalamat authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.