Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated versionless client interface methods #74422

Merged
merged 3 commits into from Feb 26, 2019

Conversation

@liggitt
Copy link
Member

liggitt commented Feb 22, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes the long-deprecated versionless external client interfaces.

As new versions of API groups are added, the version these accessors targets shifts, which can silently make an application target an unintended version when recompiled with a newer client-go library.

Does this PR introduce a user-facing change?:

client-go: the deprecated versionless API group accessors (like `clientset.Apps()` have been removed). Use an explicit version instead (like `clientset.AppsV1()`)

/sig api-machinery
/cc @sttts @lavalamp

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yliaog

This comment has been minimized.

Copy link
Contributor

yliaog commented Feb 25, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from yliaog Feb 25, 2019

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Feb 26, 2019

/lgtm

This is deprecated for so long. Let's remove it finally 👍

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 26, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

liggitt added some commits Feb 21, 2019

@liggitt liggitt force-pushed the liggitt:client-version-methods branch from 1bfd3cb to d1e865e Feb 26, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 26, 2019

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Feb 26, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 26, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 26, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

liggitt commented Feb 26, 2019

/retest

@liggitt liggitt added the lgtm label Feb 26, 2019

@k8s-ci-robot k8s-ci-robot merged commit be8a9b9 into kubernetes:master Feb 26, 2019

16 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-godeps Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:client-version-methods branch Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.