Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote admission webhook API to v1 #79549

Merged
merged 11 commits into from Jul 12, 2019

Conversation

@liggitt
Copy link
Member

commented Jun 29, 2019

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:

  • Promotes the {Validating,Mutating}WebhookConfiguration types to v1
  • failurePolicy default changed from Ignore to Fail for v1
  • matchPolicy default changed from Exact to Equivalent for v1
  • timeout default changed from 30s to 10s for v1
  • sideEffects default value is removed and the field made required for v1
  • admissionReviewVersions default value is removed and the field made required for v1
  • webhook names required to be unique when creating v1 configuration objects (#78510)
  • Adds unit tests for new defaults
  • Adds unit tests for new validation

Fixes #78510

Special notes for your reviewer:

  • The first commit just copies the existing types, changes package names, and finds/replaces v1beta1 with v1
  • The subsequent commits change or remove a specific default in the v1 API, or tighten validation in the v1 API
  • The last commit is generated files

Does this PR introduce a user-facing change?:

The `MutatingWebhookConfiguration` and `ValidatingWebhookConfiguration` APIs have been promoted to `admissionregistration.k8s.io/v1`:
* `failurePolicy` default changed from `Ignore` to `Fail` for v1
* `matchPolicy` default changed from `Exact` to `Equivalent` for v1
* `timeout` default changed from `30s` to `10s` for v1
* `sideEffects` default value is removed, and the field made required, and only `None` and `NoneOnDryRun` are permitted for v1
* `admissionReviewVersions` default value is removed and the field made required for v1 (supported versions for AdmissionReview are `v1` and `v1beta1`)
* The `name` field for specified webhooks must be unique for `MutatingWebhookConfiguration` and `ValidatingWebhookConfiguration` objects created via `admissionregistration.k8s.io/v1`
The `admissionregistration.k8s.io/v1beta1` versions of `MutatingWebhookConfiguration` and `ValidatingWebhookConfiguration` are deprecated and will no longer be served in v1.19.

/sig api-machinery
/cc @sttts @jpbetz @roycaihw

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz Jun 29, 2019

@k8s-ci-robot k8s-ci-robot requested review from roycaihw and sttts Jun 29, 2019

@liggitt liggitt added this to the v1.16 milestone Jun 29, 2019

@liggitt liggitt force-pushed the liggitt:admission-webhooks-v1 branch from eb1d207 to a8aeb29 Jun 29, 2019

@liggitt liggitt force-pushed the liggitt:admission-webhooks-v1 branch 3 times, most recently from 38632e9 to 875eac0 Jun 29, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

/retest

1 similar comment
@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

/retest

@liggitt liggitt force-pushed the liggitt:admission-webhooks-v1 branch from 875eac0 to ddad5bd Jun 29, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

/priority important-soon

@liggitt liggitt added this to Required for GA, in progress in Admission Webhooks Jul 3, 2019

@liggitt liggitt force-pushed the liggitt:admission-webhooks-v1 branch 2 times, most recently from adb446e to 8500cb2 Jul 10, 2019

@liggitt liggitt force-pushed the liggitt:admission-webhooks-v1 branch from 8500cb2 to b15aed6 Jul 10, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

/retest

@sttts

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

lgtm
/approve

/assign @smarterclayton

for final lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 11, 2019

@k8s-ci-robot k8s-ci-robot merged commit 3dd8add into kubernetes:master Jul 12, 2019

23 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt moved this from Required for GA, in progress to Complete in Admission Webhooks Jul 16, 2019

@liggitt liggitt moved this from In progress to API review completed, 1.16 in API Reviews Jul 16, 2019

@liggitt liggitt deleted the liggitt:admission-webhooks-v1 branch Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.