-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote admission webhook API to v1 #79549
Promote admission webhook API to v1 #79549
Conversation
eb1d207
to
a8aeb29
Compare
38632e9
to
875eac0
Compare
/retest |
1 similar comment
/retest |
875eac0
to
ddad5bd
Compare
/priority important-soon |
8500cb2
to
b15aed6
Compare
/retest |
lgtm /assign @smarterclayton for final lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/area admission-control |
The sideEffects field field became required in v1 version of the resource kubernetes/kubernetes#79549 Also adding failurePolicy: Ignore, because the default value has changed to Fail in v1.16. These changes are not needed for v1beta1, but I still add them for those cases as well for consistency.
…ixes #4627 (#4632) * Backend - Caching - Fixed deployer failure on Kubernetes v1.16+ The sideEffects field field became required in v1 version of the resource kubernetes/kubernetes#79549 Also adding failurePolicy: Ignore, because the default value has changed to Fail in v1.16. These changes are not needed for v1beta1, but I still add them for those cases as well for consistency. * The admissionReviewVersions field became required in the v1 API in v1.16 See https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#request
…ixes kubeflow#4627 (kubeflow#4632) * Backend - Caching - Fixed deployer failure on Kubernetes v1.16+ The sideEffects field field became required in v1 version of the resource kubernetes/kubernetes#79549 Also adding failurePolicy: Ignore, because the default value has changed to Fail in v1.16. These changes are not needed for v1beta1, but I still add them for those cases as well for consistency. * The admissionReviewVersions field became required in the v1 API in v1.16 See https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#request
…ixes kubeflow#4627 (kubeflow#4632) * Backend - Caching - Fixed deployer failure on Kubernetes v1.16+ The sideEffects field field became required in v1 version of the resource kubernetes/kubernetes#79549 Also adding failurePolicy: Ignore, because the default value has changed to Fail in v1.16. These changes are not needed for v1beta1, but I still add them for those cases as well for consistency. * The admissionReviewVersions field became required in the v1 API in v1.16 See https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#request
…ixes #4627 (#4632) * Backend - Caching - Fixed deployer failure on Kubernetes v1.16+ The sideEffects field field became required in v1 version of the resource kubernetes/kubernetes#79549 Also adding failurePolicy: Ignore, because the default value has changed to Fail in v1.16. These changes are not needed for v1beta1, but I still add them for those cases as well for consistency. * The admissionReviewVersions field became required in the v1 API in v1.16 See https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#request
…ixes kubeflow#4627 (kubeflow#4632) * Backend - Caching - Fixed deployer failure on Kubernetes v1.16+ The sideEffects field field became required in v1 version of the resource kubernetes/kubernetes#79549 Also adding failurePolicy: Ignore, because the default value has changed to Fail in v1.16. These changes are not needed for v1beta1, but I still add them for those cases as well for consistency. * The admissionReviewVersions field became required in the v1 API in v1.16 See https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#request
What type of PR is this?
/kind api-change
/kind feature
What this PR does / why we need it:
failurePolicy
default changed fromIgnore
toFail
for v1matchPolicy
default changed fromExact
toEquivalent
for v1timeout
default changed from30s
to10s
for v1sideEffects
default value is removed and the field made required for v1admissionReviewVersions
default value is removed and the field made required for v1Fixes #78510
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/sig api-machinery
/cc @sttts @jpbetz @roycaihw