Join GitHub today
feat: update taint nodes by condition to GA #82703
What this PR does / why we need it:
Graduate TaintNodesByCondition to GA
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
The node e2e integration tests are failing since we are removing the TaintNodeByCondition feature gates from the codebase.
I scanned through the PR history and found out TaintNodeByCondition was disabled on purpose in node e2e test. #73097 (comment)
If the node e2e doesn't want to run the node controller (which handles resolving this taint if I remember correctly), the node e2e will need to mimic that behavior in its setup.
In general, running partial environments in e2e tests is not recommended, because of the duplication/drift inherent in running a system different than a "real" cluster.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
/hold The integration tests is failing, I'll fix this. Regards, Draven…
On Oct 18, 2019, 6:17 PM +0800, Kubernetes Prow Robot ***@***.***>, wrote: @draveness: The following test failed, say /retest to rerun them all: Test name Commit Details Rerun command pull-kubernetes-integration f729058 link /test pull-kubernetes-integration Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.