Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update taint nodes by condition to GA #82703

Conversation

@draveness
Copy link
Member

draveness commented Sep 13, 2019

/kind feature
/sig scheduling
/priority important-soon
/assign @k82cn

What this PR does / why we need it:

Graduate TaintNodesByCondition to GA

Which issue(s) this PR fixes:

Fixes #82635

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Graduate TaintNodesByCondition to GA in 1.17. (feature gate will be removed in 1.18) action required

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@draveness draveness force-pushed the draveness:feature/graduate-taint-nodes-by-condition-to-ga branch 2 times, most recently from 32e67c2 to e82e01f Sep 16, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Sep 16, 2019

The node e2e integration tests are failing since we are removing the TaintNodeByCondition feature gates from the codebase.

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/82703/pull-kubernetes-node-e2e/1173534864813592576/

I scanned through the PR history and found out TaintNodeByCondition was disabled on purpose in node e2e test. #73097 (comment)

cc/ @bsalamat @liggitt @yujuhong, do you have any idea on how to fix this?

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Sep 16, 2019

If the node e2e doesn't want to run the node controller (which handles resolving this taint if I remember correctly), the node e2e will need to mimic that behavior in its setup.

In general, running partial environments in e2e tests is not recommended, because of the duplication/drift inherent in running a system different than a "real" cluster.

@roycaihw

This comment has been minimized.

Copy link
Member

roycaihw commented Sep 16, 2019

/remove-sig api-machinery
/sig cloud-provider

@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Sep 17, 2019

@deads2k

This comment has been minimized.

Copy link
Contributor

deads2k commented Oct 17, 2019

/approve

controller, admission, and kubeapiserver changes all look fine.

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Oct 17, 2019

/approve

@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Oct 18, 2019

/assign @tallclair
for kubelet approval

@wojtek-t

This comment has been minimized.

Copy link
Member

wojtek-t commented Oct 18, 2019

/approve

/hold
Please rebase and hold cancel.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Oct 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, deads2k, draveness, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@draveness draveness force-pushed the draveness:feature/graduate-taint-nodes-by-condition-to-ga branch from 89b423b to f729058 Oct 18, 2019
@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Oct 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 18, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Oct 18, 2019

@draveness draveness force-pushed the draveness:feature/graduate-taint-nodes-by-condition-to-ga branch from f729058 to 823183a Oct 18, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 18, 2019
@draveness draveness force-pushed the draveness:feature/graduate-taint-nodes-by-condition-to-ga branch from 823183a to 1163a1d Oct 19, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

draveness commented Oct 19, 2019

/retest

@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Oct 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 19, 2019
@ahg-g

This comment has been minimized.

Copy link
Member

ahg-g commented Oct 19, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit aab740f into kubernetes:master Oct 19, 2019
17 checks passed
17 checks passed
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-alpha-features Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 19, 2019
@draveness draveness deleted the draveness:feature/graduate-taint-nodes-by-condition-to-ga branch Oct 19, 2019
@draveness draveness mentioned this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.