feat: update taint nodes by condition to GA #82703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k82cn
reviewed
Sep 14, 2019
k8s-ci-robot
added
size/L
draveness
force-pushed
the
feature/graduate-taint-nodes-by-condition-to-ga
branch
2 times, most recently
from
32e67c2 to
e82e01f
Compare
|
The node e2e integration tests are failing since we are removing the TaintNodeByCondition feature gates from the codebase. I scanned through the PR history and found out TaintNodeByCondition was disabled on purpose in node e2e test. #73097 (comment) cc/ @bsalamat @liggitt @yujuhong, do you have any idea on how to fix this? |
|
If the node e2e doesn't want to run the node controller (which handles resolving this taint if I remember correctly), the node e2e will need to mimic that behavior in its setup. In general, running partial environments in e2e tests is not recommended, because of the duplication/drift inherent in running a system different than a "real" cluster. |
|
/remove-sig api-machinery |
k8s-ci-robot
added
sig/cloud-provider
deads2k
reviewed
Oct 17, 2019
deads2k
reviewed
Oct 17, 2019
|
/approve controller, admission, and kubeapiserver changes all look fine. |
|
/approve |
|
/assign @tallclair |
|
/approve /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, deads2k, draveness, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
draveness
force-pushed
the
feature/graduate-taint-nodes-by-condition-to-ga
branch
from
89b423b to
f729058
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold
The integration tests is failing, I'll fix this.
Regards,
Draven
…On Oct 18, 2019, 6:17 PM +0800, Kubernetes Prow Robot ***@***.***>, wrote:
@draveness: The following test failed, say /retest to rerun them all:
Test name
Commit
Details
Rerun command
pull-kubernetes-integration
f729058
link
/test pull-kubernetes-integration
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
draveness
force-pushed
the
feature/graduate-taint-nodes-by-condition-to-ga
branch
from
f729058 to
823183a
Compare
k8s-ci-robot
removed
the
lgtm
draveness
force-pushed
the
feature/graduate-taint-nodes-by-condition-to-ga
branch
from
823183a to
1163a1d
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced Oct 19, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
/sig scheduling
/priority important-soon
/assign @k82cn
What this PR does / why we need it:
Graduate TaintNodesByCondition to GA
Which issue(s) this PR fixes:
Fixes #82635
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: