Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taint node by Condition #382

Closed
k82cn opened this issue Aug 4, 2017 · 78 comments
Closed

Taint node by Condition #382

k82cn opened this issue Aug 4, 2017 · 78 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@k82cn
Copy link
Member

k82cn commented Aug 4, 2017

Feature Description

@k82cn
Copy link
Member Author

k82cn commented Aug 4, 2017

xref kubernetes/kubernetes#42001

@k82cn
Copy link
Member Author

k82cn commented Aug 4, 2017

@calebamiles , this one is also target to 1.8; the tasks are traced at kubernetes/kubernetes#42001 .

@idvoretskyi
Copy link
Member

idvoretskyi commented Aug 9, 2017

@k82cn the feature submission deadline has passed (Aug 1). Please, submit a feature exception (https://github.com/kubernetes/features/blob/master/EXCEPTIONS.md) to have this feature present in 1.8 release.

@idvoretskyi idvoretskyi added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Aug 9, 2017
@gmarek
Copy link

gmarek commented Aug 11, 2017

@idvoretskyi - it's not appropriate exception template. The feature will be ready in time, and filing an exception for filing a feature description is not covered there.

@jdumars
Copy link
Member

jdumars commented Aug 16, 2017

@k82cn @gmarek it appears that this feature has been in progress for some time, but the feature repo issue was just filed late. Is that correct? In any case, we need you to complete the one-line description of the feature and add to the release notes draft so the user community can appreciate the great work you've done.

@gmarek
Copy link

gmarek commented Aug 16, 2017

@jdumars - sure, this makes sense. Where is the release notes draft that we should add it to?

@jdumars
Copy link
Member

jdumars commented Aug 16, 2017

@k82cn
Copy link
Member Author

k82cn commented Aug 17, 2017

thanks; I'll follow up to draft a release note.

@k82cn
Copy link
Member Author

k82cn commented Aug 21, 2017

xref #398

@k82cn
Copy link
Member Author

k82cn commented Aug 23, 2017

Should we add 1.8 milestone ?

@jdumars jdumars added this to the 1.8 milestone Aug 23, 2017
@luxas
Copy link
Member

luxas commented Aug 26, 2017

@k82cn alpha or beta targeted for v1.8?

@k82cn
Copy link
Member Author

k82cn commented Aug 26, 2017

alpha release target is 1.8 :).

@luxas luxas added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Aug 26, 2017
@luxas
Copy link
Member

luxas commented Aug 26, 2017

Perfect, thank you!

@davidopp
Copy link
Member

davidopp commented Sep 7, 2017

Is the work for this to go to alpha finished? I couldn't quite figure it out from reading kubernetes/kubernetes#42001

@k82cn
Copy link
Member Author

k82cn commented Sep 9, 2017

@davidopp , all function code were done; I'll add e2e test early this week, and gmarek@ had created PR for doc. The task list in kubernetes/kubernetes#42001 shows what had done.

@fejta-bot
Copy link

fejta-bot commented Jan 5, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2018
@k82cn
Copy link
Member Author

k82cn commented Jan 9, 2018

/remove-lifecycle stale

We're going to trace alpha->beta in this issue.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2018
@k82cn
Copy link
Member Author

k82cn commented Apr 4, 2018

Beta release target (1.11)

@k82cn
Copy link
Member Author

k82cn commented Apr 10, 2018

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 10, 2018
@justaugustus
Copy link
Member

justaugustus commented Apr 17, 2018

@k82cn
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@k82cn
Copy link
Member Author

k82cn commented Apr 17, 2018

  • Milestone: 1.11
  • Assignee(s): @k82cn
  • Labels:

/stage beta
/sig node
/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2018
@evillgenius75
Copy link

evillgenius75 commented Jul 9, 2019

Hi @k82cn @bsalamat , I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements. You can see the graduation criteria which is required information per the KEP Template.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@k82cn
Copy link
Member Author

k82cn commented Sep 12, 2019

we'd like to promote this feature to GA in 1.17 :)

@kacole2 kacole2 added this to the v1.17 milestone Sep 12, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 23, 2019

👋 hey there @k82cn -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@palnabarun
Copy link
Member

palnabarun commented Oct 10, 2019

Hi @k82cn, -- 1.17 enhancements shadow here.

Just a friendly reminder. We are just 5 days away from the Enhancements Freeze.

For the KEP to be considered for 1.17,

  1. KEP PR must be merged
  2. KEP should be in an implementable state
  3. KEP should have test plans and graduation criteria.

@k82cn
Copy link
Member Author

k82cn commented Oct 12, 2019

1.17 enhancements shadow here.

ack :)

@mrbobbytables mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 13, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Oct 15, 2019

It looks like a KEP was merged yesterday, and references previous tests. Is there anyway it can be updated to link to those or possibly a testgrid dashboard?

Also is there anything else that is going to be done to bump it to GA? or is more 'it's been stable enough that we have enough signal to promote to GA'?

Thanks!

@guineveresaenger
Copy link

guineveresaenger commented Oct 16, 2019

Hi there, release 1.17 lead here. :)

I would like to second the concern about missing visibility into a testgrid dashboard for this. Can you please update the KEP with a link?

@draveness
Copy link
Member

draveness commented Oct 17, 2019

Hi there, release 1.17 lead here. :)

I would like to second the concern about missing visibility into a testgrid dashboard for this. Can you please update the KEP with a link?

I'll send the PR to update the KEP, thanks for the reminder.

@irvifa
Copy link
Member

irvifa commented Oct 21, 2019

Hello @k82cn I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@draveness
Copy link
Member

draveness commented Oct 21, 2019

Hello @mrbobbytales I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

I created kubernetes/website#17073 to update the documents, but I'm not sure whether it is all the documents we need to update.

@irvifa
Copy link
Member

irvifa commented Oct 21, 2019

I'm also not sure about that either. cc @k82cn In any case you know about this taint nodes by condition..

@daminisatya
Copy link
Member

daminisatya commented Nov 2, 2019

@draveness @k82cn Can you confirm if this is the final doc? - kubernetes/website#17073

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Nov 4, 2019

Hey there 👋. Jeremy from the 1.17 enhancements team here. Code freeze is coming up quickly (Nov 14) and I wanted to touch base to see how this was going. Are there any in progress k/k PRs that we can track for the work getting this to GA? I see docs PRs associated with this, are there any other PRs we should be tracking for the release?

@draveness
Copy link
Member

draveness commented Nov 8, 2019

Hey there 👋. Jeremy from the 1.17 enhancements team here. Code freeze is coming up quickly (Nov 14) and I wanted to touch base to see how this was going. Are there any in progress k/k PRs that we can track for the work getting this to GA? I see docs PRs associated with this, are there any other PRs we should be tracking for the release?

Here is the PR for the code change kubernetes/kubernetes#82703 and related issue kubernetes/kubernetes#82635

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 3, 2020

Hey @draveness @k82cn, Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

@jeremyrickard jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020
@draveness
Copy link
Member

draveness commented Jan 3, 2020

Hey @draveness @k82cn, Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

This feature has already graduated to GA, I think we could close it now.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 3, 2020

@draveness: Closing this issue.

In response to this:

Hey @draveness @k82cn, Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

This feature has already graduated to GA, I think we could close it now.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 3, 2020

@draveness yes, I was just asking if you could update the status of the KEP :) It's still marked as implementable, but should be updated to say implemented...since it was :)

@draveness
Copy link
Member

draveness commented Jan 7, 2020

@draveness yes, I was just asking if you could update the status of the KEP :) It's still marked as implementable, but should be updated to say implemented...since it was :)

Thanks for the reminder, #1431 has been merged,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests