New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taint node by Condition #382

Open
k82cn opened this Issue Aug 4, 2017 · 41 comments

Comments

Projects
None yet
@k82cn
Member

k82cn commented Aug 4, 2017

Feature Description

@k82cn

This comment has been minimized.

Member

k82cn commented Aug 4, 2017

@k82cn

This comment has been minimized.

Member

k82cn commented Aug 4, 2017

@calebamiles , this one is also target to 1.8; the tasks are traced at kubernetes/kubernetes#42001 .

@idvoretskyi

This comment has been minimized.

Member

idvoretskyi commented Aug 9, 2017

@k82cn the feature submission deadline has passed (Aug 1). Please, submit a feature exception (https://github.com/kubernetes/features/blob/master/EXCEPTIONS.md) to have this feature present in 1.8 release.

@gmarek

This comment has been minimized.

Member

gmarek commented Aug 11, 2017

@idvoretskyi - it's not appropriate exception template. The feature will be ready in time, and filing an exception for filing a feature description is not covered there.

@jdumars

This comment has been minimized.

Member

jdumars commented Aug 16, 2017

@k82cn @gmarek it appears that this feature has been in progress for some time, but the feature repo issue was just filed late. Is that correct? In any case, we need you to complete the one-line description of the feature and add to the release notes draft so the user community can appreciate the great work you've done.

@gmarek

This comment has been minimized.

Member

gmarek commented Aug 16, 2017

@jdumars - sure, this makes sense. Where is the release notes draft that we should add it to?

@jdumars

This comment has been minimized.

@k82cn

This comment has been minimized.

Member

k82cn commented Aug 17, 2017

thanks; I'll follow up to draft a release note.

@k82cn

This comment has been minimized.

Member

k82cn commented Aug 21, 2017

xref #398

@k82cn

This comment has been minimized.

Member

k82cn commented Aug 23, 2017

Should we add 1.8 milestone ?

@jdumars jdumars added this to the 1.8 milestone Aug 23, 2017

@luxas

This comment has been minimized.

Member

luxas commented Aug 26, 2017

@k82cn alpha or beta targeted for v1.8?

@k82cn

This comment has been minimized.

Member

k82cn commented Aug 26, 2017

alpha release target is 1.8 :).

@luxas luxas added the stage/alpha label Aug 26, 2017

@luxas

This comment has been minimized.

Member

luxas commented Aug 26, 2017

Perfect, thank you!

@davidopp

This comment has been minimized.

Member

davidopp commented Sep 7, 2017

Is the work for this to go to alpha finished? I couldn't quite figure it out from reading kubernetes/kubernetes#42001

@k82cn

This comment has been minimized.

Member

k82cn commented Sep 9, 2017

@davidopp , all function code were done; I'll add e2e test early this week, and gmarek@ had created PR for doc. The task list in kubernetes/kubernetes#42001 shows what had done.

@fejta-bot

This comment has been minimized.

fejta-bot commented Jan 5, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k82cn

This comment has been minimized.

Member

k82cn commented Jan 9, 2018

/remove-lifecycle stale

We're going to trace alpha->beta in this issue.

@k82cn

This comment has been minimized.

Member

k82cn commented Apr 4, 2018

Beta release target (1.11)

@k82cn

This comment has been minimized.

Member

k82cn commented Apr 10, 2018

/sig node

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@k82cn
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@k82cn

This comment has been minimized.

Member

k82cn commented Apr 17, 2018

  • Milestone: 1.11
  • Assignee(s): @k82cn
  • Labels:

/stage beta
/sig node
/kind feature

@justaugustus justaugustus added stage/beta and removed stage/alpha labels Apr 20, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 20, 2018

Thanks for the update!

@mistyhacks

This comment has been minimized.

mistyhacks commented May 24, 2018

@k82cn please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@zparnold

This comment has been minimized.

Member

zparnold commented May 30, 2018

@k82cn Looks like we still need some docs to get this feature ready for release
#382
Could I please have your help with that? If there’s anything I can do to assist please let me know

@k82cn

This comment has been minimized.

Member

k82cn commented May 31, 2018

/milestone v1.12

@mistyhacks , @zparnold , after go through the status, there're still 4 PRs under review; it's hard to catch up 1.11. So I'd like to move this to next release.

@jberkus jberkus modified the milestones: v1.11, v1.12 May 31, 2018

@mistyhacks

This comment has been minimized.

mistyhacks commented May 31, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@k82cn @kubernetes/sig-node-feature-requests @kubernetes/sig-scheduling-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Jul 23, 2018

@justaugustus I'm helping @k82cn to promote this feature to beta in 1.12

Here is the info:

  • Description: Represent node conditions that block scheduling using taints
  • Assignee(s): @k82cn
  • Labels:
    • stage/beta
    • sig/scheduling, sig/node
    • kind/feature

Upgrade TaintNodesByCondition to Beta #62109 records everything related with code changes and website changes.

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Jul 23, 2018

website doc update: kubernetes/website#9626

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 25, 2018

Thanks for the update! This has been added to the 1.12 Tracking sheet.

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @k82cn I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Aug 20, 2018

@zparnold here is the one kubernetes/website#9626

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

@ameukam

This comment has been minimized.

Contributor

ameukam commented Oct 5, 2018

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 5, 2018

@ameukam this feature has been promoted to beta in 1.12, and we don't plan to promote it to GA in 1.13.

So removing milestone label is fine.

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 5, 2018

/milestone clear

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 5, 2018

@Huang-Wei: You must be a member of the kubernetes/kubernetes-milestone-maintainers github team to set the milestone.

In response to this:

/milestone clear

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Oct 5, 2018

@kacole2 could you help to clear the milestone label? Thanks.

@k82cn

This comment has been minimized.

Member

k82cn commented Oct 5, 2018

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Oct 5, 2018

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Oct 6, 2018

@gliush

This comment has been minimized.

gliush commented Oct 6, 2018

@k82cn

This comment has been minimized.

Member

k82cn commented Oct 7, 2018

@gliush , thanks; updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment