-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduates the DisableAcceleratorUsageMetrics feature to beta #95184
Graduates the DisableAcceleratorUsageMetrics feature to beta #95184
Conversation
/sig node |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/lgtm |
@@ -633,7 +633,7 @@ const ( | |||
WinDSR featuregate.Feature = "WinDSR" | |||
|
|||
// owner: @RenaudWasTaken @dashpole | |||
// alpha: v1.19 | |||
// beta: v1.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep the alpha version entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// beta: v1.20 | |
// alpha: v1.19 | |
// beta: v1.20 |
d2919a4
to
c5fc646
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekwaynecarr, RenaudWasTaken The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it: Graduates the DisableAcceleratorUsageMetrics feature to beta
Which issue(s) this PR fixes: See kubernetes/enhancements#1867 (but does not fix)
Special notes for your reviewer: Will need to wait for the (kep)[https://github.com/kubernetes/enhancements/pull/2036] to be updated
Does this PR introduce a user-facing change?: Yes!
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: