Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce api-extensions category in k8s apiserver #95603

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Introduce api-extensions category in k8s apiserver #95603

merged 1 commit into from
Nov 4, 2020

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Oct 15, 2020

What type of PR is this?
/kind feature
/sig api-machinery
/priority important-longterm

What this PR does / why we need it:
Introduce api-extensions category in k8s apiserver, this category includes:

  1. mutating admission configs
  2. validating admission configs
  3. CRDs
  4. APIServices

Which issue(s) this PR fixes:
Fixes #95280

Special notes for your reviewer:
/assign @deads2k

Does this PR introduce a user-facing change?:

Introduce api-extensions category which will return: mutating admission configs, validating admission configs, CRDs and APIServices when used in kubectl get, for example.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 15, 2020
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 15, 2020
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 15, 2020
@soltysh
Introduce api-extensions category in k8s apiserver
9a4dfec 
This category includes:
1. mutating admission configs
2. validating admission configs
3. CRDs
4. APIServices
@soltysh
Copy link
Contributor Author

soltysh commented Nov 4, 2020

/retest

@deads2k
Copy link
Contributor

deads2k commented Nov 4, 2020

this matches what we discussed in the sig call
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 56c1be8 into kubernetes:master Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 4, 2020
@soltysh soltysh deleted the api_extensions branch November 5, 2020 12:34
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Open
@soltysh soltysh mentioned this pull request Nov 8, 2021
Closed
@NikhilSharmaWe NikhilSharmaWe mentioned this pull request Nov 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbohlool mbohlool Awaiting requested review from mbohlool

@piosz piosz Awaiting requested review from piosz

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Create a "group" for accessing webhooks via kubectl
4 participants
@soltysh @fedebongio @deads2k @k8s-ci-robot