New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Builders for client-go's typed client #99012
Apply Builders for client-go's typed client #99012
Conversation
/triage accepted |
@jpbetz: GitHub didn't allow me to request PR reviews from the following users: kevindelgado. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ff249d2
to
4c0b3db
Compare
ce90ebf
to
661665a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at a few generated types, it looks good in general, I'm just trying to understand some decisions (probably because I don't have enough context of the implementation details).
staging/src/k8s.io/client-go/applyconfigurations/admissionregistration/v1/mutatingwebhook.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/client-go/applyconfigurations/admissionregistration/v1/mutatingwebhook.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/code-generator/cmd/applyconfiguration-gen/generators/applyconfiguration.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/client-go/applyconfigurations/admissionregistration/v1/mutatingwebhook.go
Outdated
Show resolved
Hide resolved
staging/src/k8s.io/client-go/applyconfigurations/admissionregistration/v1/mutatingwebhook.go
Outdated
Show resolved
Hide resolved
548691e
to
ac853e8
Compare
/retest Review the full test history for this PR. Silence the bot with an |
/hold |
/hold cancel |
/hold |
/hold cancel |
05e7015
to
cfb4c66
Compare
Rebased and fix a corner case we found when implementing extract-- non-inlined embeds must be nill-able. Some details at: https://gist.github.com/jpbetz/a5a3a8dd0f12641e8546a9c1a525ea3f |
cfb4c66
to
885e04b
Compare
/lgtm |
885e04b
to
86184be
Compare
Rebased and reran generator to pick up added |
@jpbetz: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is the first step toward implementing Apply for client-go's typed client
umbrella issue: kubernetes/enhancements#2155
Special notes for your reviewer:
Generated code is in a separate commit.
Example usage:
Does this PR introduce a user-facing change?:
Release note will be added when all the last change in the umbrella issue is merged
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig api-machinery
/wg api-expression