Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded sudo from commands and make it conditional #12460

Closed
spowelljr opened this issue Sep 13, 2021 · 6 comments · Fixed by #13829
Closed

Remove hardcoded sudo from commands and make it conditional #12460

spowelljr opened this issue Sep 13, 2021 · 6 comments · Fixed by #13829
Labels
co/podman-driver podman driver issues kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@spowelljr
Copy link
Member

spowelljr commented Sep 13, 2021 •
edited
Loading

#8719 (comment)
@spowelljr spowelljr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/improvement Categorizes issue or PR as related to improving upon a current feature. labels Sep 13, 2021
@jayesh-srivastava
Copy link
Member

Hi. I would like to work on this issue. Can you please explain a bit further?

@jayesh-srivastava
Copy link
Member

/assign

@afbjorklund
Copy link
Collaborator

There is supposed to be a new boolean "rootless", and when it is true we should not use sudo when calling podman.

For docker we never use sudo (but the root-equivalent group), so there is no need to change that code for the boolean.

@afbjorklund afbjorklund added the co/podman-driver podman driver issues label Sep 15, 2021
@afbjorklund afbjorklund mentioned this issue Sep 25, 2021
Open
@afbjorklund afbjorklund removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Sep 25, 2021
@AkihiroSuda AkihiroSuda mentioned this issue Nov 9, 2021
Closed
@AkihiroSuda
Copy link
Member

PR: #12901

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2022
@AkihiroSuda
Copy link
Member

/remove-lifecycle stale

PR #12901 is waiting for reviewing/merging

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2022
@AkihiroSuda AkihiroSuda mentioned this issue Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
co/podman-driver podman driver issues kind/improvement Categorizes issue or PR as related to improving upon a current feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
6 participants
@AkihiroSuda @afbjorklund @k8s-ci-robot @spowelljr @jayesh-srivastava @k8s-triage-robot