-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum supported podman version #19232
Comments
/assign |
@xcarolan if it helps here is a PR I made on the setup-minikube github action here is a run on ubuntu 22.04 and here is a run on ubuntu 24.04
and interestingly it works ! https://github.com/medyagh/setup-minikube/actions/runs/9943998728 so the issue is we need make set a mininum version supported by minkube to be podman 4 (or [possibily 4.9) so when the user runs it with Older podman minikube should quit nicely here is the part of the code https://github.com/medyagh/minikube/blob/8585f4395093245ed0b8510269cc192bf948bedd/pkg/minikube/registry/drvs/podman/podman.go#L44 |
This is awesome thanks!
Samantha
Sent with [Proton Mail](https://proton.me/) secure email.
…On Monday, July 15th, 2024 at 1:42 PM, Medya Ghazizadeh ***@***.***> wrote:
***@***.***(https://github.com/xcarolan) if it helps here is a PR I made on the setup-minikube github action
[medyagh/setup-minikube#496](medyagh/setup-minikube#496)
here is a run on ubuntu 22.04
https://github.com/medyagh/setup-minikube/actions/runs/9943952476/job/27468892104?pr=496
which installs podman 3
and here is a run on ubuntu 24.04
there it installs
Client: Podman Engine
Version: 4.9.3
API Version: 4.9.3
and interestingly it works ! https://github.com/medyagh/setup-minikube/actions/runs/9943998728
so the issue is we need make set a mininum version supported by minkube to be podman 4 (or [possibily 4.9) so when the user runs it with Older podman minikube should quit nicely
here is the part of the code https://github.com/medyagh/minikube/blob/8585f4395093245ed0b8510269cc192bf948bedd/pkg/minikube/registry/drvs/podman/podman.go#L44
—
Reply to this email directly, [view it on GitHub](#19232 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADZIRHSEQ7R6BHEINPIT323ZMQCYPAVCNFSM6AAAAABKVYSROKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGA2TANJVG4).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
It just bumped the CI version of OS, it did not increase the minimum supported Podman version. Some versions of Ubuntu and Podman still have older versions of 4.x, though (upstream only does 5.x) |
thanks Anders, sorry for the confusion - i'll reopen the issue then |
Debian uses 4.3.1, so one arbitrary minimum version would be 4.2 // minReqPodmanVer is required the minimum version of podman to be installed for podman driver.
var minReqPodmanVer = semver.Version{Major: 2, Minor: 1, Patch: 0} Or drop support for Debian 12 and Ubuntu 23.10, another option? |
i actually have a patch for this - I'm just verifying some additional changes. |
Whatever the new version is, it should be verified that it actually works... |
The change I have is specifically for the Podman driver: `// minReqPodmanVer is required the minimum version of podman to be installed for podman driver. Along this i'm trying to understand the history behind: |
There were some hardcoded calls to docker, in the image loading code - needs a podman version. download.CacheToDaemon Here was the upstream issue, possibly you could use the Docker API also for podman: |
Thanks! |
Podman has been failing on github action for a long time lets take a stab at it here are the info
podman version
Logs (example https://github.com/kubernetes/minikube/actions/runs/9881717147/job/27293245071?pr=19229)
First error is in downloading image that refers to "#8426"
I need help someone to look up that issue and see if we can implement that now or it still cant be implemented yet.
and creating container fails, there seem to be many ppl with same logs #18759
also it worth trying to use --force-system in github action to see if that fixes it
The text was updated successfully, but these errors were encountered: