The DefaultKubernetesRepo changed for 1.25.0 #14768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
afbjorklund
force-pushed
the
kubeadm-registry
branch
from
67398d3
to
a6046dd
Compare
Moving the old images for the old releases would mean having to redo old preloads and old caches, as well...
afbjorklund
force-pushed
the
kubeadm-registry
branch
from
a6046dd
to
6f7c585
Compare
|
@medyagh : why is the old minikube storage-provisioner included, in the "kubeadm" images ? imgs := essentials(mirror, v)
imgs = append(imgs, auxiliary(mirror)...)Shouldn't it be a separate addition, since it does not originate from the |
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
spowelljr
approved these changes
Aug 31, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: kubernetes/kubernetes@50bea1d
Changing the old releases would mean having to redo the old preload as well.
But it could be a good idea to make sure that 1.25.0 comes out the right way...