Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Headlamp version to 0.19.1 #17135

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

joaquimrocha
Copy link
Contributor

Upgrade Headlamp version to 0.19.1
cc: @joaquimrocha

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @joaquimrocha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2023
@spowelljr
Copy link
Member

/retest-this-please

@spowelljr
Copy link
Member

@joaquimrocha Could you rebase this PR or close it and use your automation to create a new one? I think it may be branched off a bad commit, it keeps failing to build in Jenkins.

@joaquimrocha
Copy link
Contributor Author

For sure. I'm afk now but will do tomorrow.
Thanks for the reminder.

Signed-off-by: joaquimrocha <joaquimrocha@users.noreply.github.com>
@joaquimrocha
Copy link
Contributor Author

Couldn't do it yesterday in the end. But rebased now against the latest upstream master. Hopefully it's fine.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17135) |
+----------------+----------+---------------------+
| minikube start | 50.3s    | 50.2s               |
| enable ingress | 28.3s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube start: 50.4s 49.7s 49.9s 49.9s 51.8s
Times for minikube (PR 17135) start: 52.4s 48.3s 49.3s 49.3s 51.5s

Times for minikube ingress: 27.7s 28.2s 29.1s 29.6s 27.2s
Times for minikube (PR 17135) ingress: 28.2s 27.7s 28.1s 26.1s 28.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17135) |
+----------------+----------+---------------------+
| minikube start | 23.0s    | 22.6s               |
| enable ingress | 22.8s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 21.4s 29.8s 20.8s 21.4s 20.8s
Times for minikube (PR 17135) ingress: 21.8s 22.3s 20.8s 21.8s 20.8s

Times for minikube start: 21.1s 22.6s 24.5s 21.8s 24.9s
Times for minikube (PR 17135) start: 22.3s 23.0s 24.1s 21.9s 22.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17135) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 22.0s               |
| enable ingress | 32.9s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.1s 24.1s 21.0s 23.7s 23.4s
Times for minikube (PR 17135) start: 20.3s 24.2s 21.5s 21.1s 23.0s

Times for minikube (PR 17135) ingress: 31.3s 31.3s 19.4s 47.3s 31.3s
Times for minikube ingress: 36.3s 32.3s 31.3s 32.3s 32.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestOffline (gopogh) 1.19 (chart)
Hyperkit_macOS TestAddons/Setup (gopogh) 2.38 (chart)

To see the flake rates of all tests by environment, click here.

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now, thanks!

@spowelljr spowelljr merged commit 6081f8d into kubernetes:master Sep 20, 2023
21 of 34 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joaquimrocha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@joaquimrocha
Copy link
Contributor Author

Works now, thanks!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants