-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Headlamp version to 0.19.1 #17135
Upgrade Headlamp version to 0.19.1 #17135
Conversation
Hi @joaquimrocha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
/ok-to-test |
/retest-this-please |
@joaquimrocha Could you rebase this PR or close it and use your automation to create a new one? I think it may be branched off a bad commit, it keeps failing to build in Jenkins. |
For sure. I'm afk now but will do tomorrow. |
Signed-off-by: joaquimrocha <joaquimrocha@users.noreply.github.com>
83dba35
to
f8fad71
Compare
Couldn't do it yesterday in the end. But rebased now against the latest upstream master. Hopefully it's fine. |
kvm2 driver with docker runtime
Times for minikube start: 50.4s 49.7s 49.9s 49.9s 51.8s Times for minikube ingress: 27.7s 28.2s 29.1s 29.6s 27.2s docker driver with docker runtime
Times for minikube ingress: 21.4s 29.8s 20.8s 21.4s 20.8s Times for minikube start: 21.1s 22.6s 24.5s 21.8s 24.9s docker driver with containerd runtime
Times for minikube start: 23.1s 24.1s 21.0s 23.7s 23.4s Times for minikube (PR 17135) ingress: 31.3s 31.3s 19.4s 47.3s 31.3s |
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now, thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joaquimrocha, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you! |
Upgrade Headlamp version to 0.19.1
cc: @joaquimrocha