Create Hyper-V External Switch #6264

laozc · 2020-01-10T05:52:42Z

This PR tries to find an external switch or create one for Hyper-V driver if the user specifies -hyperv-use-external-switch.

If the adapter is not specified, the driver will first look up LAN adapters before other adapters (WiFi, ...).
Or the user may specify an adapter to attach to the external switch.

Since Windows 10 only allows one external switch for the same adapter, it will find the virtual switch before creating one. The external switch will be created and named as "minikube" if not the case.

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

k8s-ci-robot · 2020-01-10T05:52:50Z

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2020-01-10T05:53:03Z

Can one of the admins verify this patch?

k8s-ci-robot · 2020-01-10T05:53:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laozc
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov-io · 2020-01-10T05:57:42Z

Codecov Report

Merging #6264 into master will increase coverage by 0.12%.
The diff coverage is 66.46%.

@@            Coverage Diff            @@
##           master   #6264      +/-   ##
=========================================
+ Coverage   37.97%   38.1%   +0.12%     
=========================================
  Files         138     137       -1     
  Lines        8714    8690      -24     
=========================================
+ Hits         3309    3311       +2     
+ Misses       4987    4963      -24     
+ Partials      418     416       -2

Impacted Files	Coverage Δ
pkg/minikube/bootstrapper/bootstrapper.go	`0% <ø> (ø)`	⬆️
pkg/minikube/cluster/start.go	`51.37% <ø> (ø)`	⬆️
pkg/minikube/bootstrapper/bsutil/versions.go	`81.81% <ø> (ø)`	⬆️
cmd/minikube/cmd/delete.go	`25.12% <0%> (ø)`	⬆️
pkg/minikube/bootstrapper/bsutil/kubeadm.go	`82.6% <100%> (+0.51%)`	⬆️
pkg/minikube/cruntime/crio.go	`53.12% <100%> (+6.25%)`	⬆️
pkg/minikube/cruntime/docker.go	`42.4% <100%> (+4.79%)`	⬆️
pkg/minikube/bootstrapper/bsutil/extraconfig.go	`80.82% <100%> (+1.71%)`	⬆️
cmd/minikube/cmd/start.go	`22.59% <33.33%> (-0.12%)`	⬇️
cmd/minikube/cmd/env.go	`57.37% <62.18%> (+0.46%)`	⬆️
... and 3 more

medyagh · 2020-01-10T23:50:06Z

@laozc I am curious why the formatting changed so much ? we run goimports -w on all the code...it should be same ...

RA489 · 2020-01-13T06:49:20Z

/ok-to-test

minikube-bot · 2020-01-13T07:09:56Z

All Times minikube: [ 122.082626 121.300649 126.761437]
All Times Minikube (PR 6264): [ 121.384663 111.825862 111.659941]

Average minikube: 123.381571
Average Minikube (PR 6264): 114.956822

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6264) |
+----------------------+-----------+--------------------+
| minikube v           |  0.430779 |           0.404907 |
| Creating kvm2        | 46.968129 |          45.965266 |
| Preparing Kubernetes | 50.305746 |          43.643313 |
| Pulling images       |  2.822725 |           2.459825 |
| Launching Kubernetes | 20.199817 |          19.360840 |
| Waiting for cluster  |  2.610544 |           3.080574 |
| Done                 |           |                    |
|                      |  0.043807 |           0.042096 |
+----------------------+-----------+--------------------+

laozc · 2020-01-13T07:16:19Z

@laozc I am curious why the formatting changed so much ? we run goimports -w on all the code...it should be same ...

Do you mean the formatting in cmd/minikube/cmd/start.go and pkg/minikube/config/types.go?
I think golang would try to align the definition by column and the new field hypervUseExternalSwitch is one character more than existing fields.

minikube-bot · 2020-01-17T18:51:01Z

Error: running mkcmp: exit status 1

minikube-bot · 2020-01-17T18:54:49Z

Error: running mkcmp: exit status 1

minikube-pr-bot · 2020-01-17T18:58:18Z

Error: running mkcmp: exit status 1

minikube-pr-bot · 2020-01-22T20:37:53Z

All Times minikube: [ 116.244172 112.958288 114.386224]
All Times Minikube (PR 6264): [ 244.793081 225.304119 225.218155]

Average minikube: 114.529561
Average Minikube (PR 6264): 231.771785

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6264) |
+----------------------+-----------+--------------------+
| minikube v           |  0.284735 |           0.293265 |
| Creating kvm2        | 41.023519 |         160.967011 |
| Preparing Kubernetes | 46.634871 |          40.757989 |
| Pulling images       |  3.971491 |           2.407591 |
| Launching Kubernetes | 19.817252 |          24.752266 |
| Waiting for cluster  |  2.747079 |           2.542124 |
+----------------------+-----------+--------------------+

pkg/minikube/registry/drvs/hyperv/vswitch.go

minikube-pr-bot · 2020-02-03T11:26:01Z

All Times Minikube (PR 6264): [ 229.077501 246.523218 231.590488]
All Times minikube: [ 95.276105 92.479505 96.625606]

Average minikube: 94.793739
Average Minikube (PR 6264): 235.730402

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6264) |
+----------------------+-----------+--------------------+
| minikube v           |  0.433618 |           0.314531 |
| Creating kvm2        | 20.156116 |         161.218599 |
| Preparing Kubernetes | 48.477586 |          42.959591 |
| Pulling images       |  3.540941 |           2.239183 |
| Launching Kubernetes | 18.619572 |          24.274581 |
| Waiting for cluster  |  1.401563 |           2.732030 |
+----------------------+-----------+--------------------+

medyagh · 2020-02-05T18:28:51Z

@laozc thanks for resolving the code reviews, letss resolve the conflicts and I think we could merge this !

tstromberg · 2020-02-05T19:27:05Z

Merge conflict, but otherwise seems to be ready!

minikube-pr-bot · 2020-02-06T03:16:33Z

All Times minikube: [ 99.851257 95.978568 94.742635]
All Times Minikube (PR 6264): [ 97.467316 97.596322 101.248441]

Average minikube: 96.857486
Average Minikube (PR 6264): 98.770693

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6264) |
+----------------------+-----------+--------------------+
| minikube v           |  0.160111 |           0.224438 |
| Creating kvm2        | 19.784521 |          20.000718 |
| Preparing Kubernetes | 50.664457 |          51.084255 |
| Pulling images       |  3.848554 |           3.386625 |
| Launching Kubernetes | 20.645624 |          20.453880 |
| Waiting for cluster  |  0.051469 |           1.726974 |
+----------------------+-----------+--------------------+

tstromberg · 2020-02-07T07:30:04Z

/ok-to-test

medyagh · 2020-02-08T00:54:14Z

@laozc thank you for your patience and thank you for resolving the conflict a few times, I promise this be the last time and your PR will get a high priority to be merged.

thank you again

minikube-pr-bot · 2020-02-08T02:32:10Z

All Times minikube: [ 93.260324 93.643328 93.578822]
All Times Minikube (PR 6264): [ 93.296713 93.047563 94.122484]

Average minikube: 93.494158
Average Minikube (PR 6264): 93.488920

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6264) |
+----------------------+-----------+--------------------+
| minikube v           |  0.127772 |           0.125245 |
| Creating kvm2        | 19.959462 |          20.075174 |
| Preparing Kubernetes | 50.702470 |          50.983311 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.504717 |          20.676903 |
| Waiting for cluster  |  0.561666 |           0.047047 |
+----------------------+-----------+--------------------+

medyagh · 2020-02-08T04:22:28Z

Thank you very much

laozc added 6 commits December 31, 2019 14:29

Create and manager Hyper-V switch

68ba364

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

Adds new flag for Hyper-V driver

57b1e14

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

Fixes test case

81ecf0e

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

Fixes configure interface change for non-HyperV drivers

e43ed04

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

Merge remote-tracking branch 'origin/master' into hyperv-external-switch

0a69a86

hypervUseExternalSwitch should be defined as bool flag

8f5029e

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2020

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 10, 2020

k8s-ci-robot requested review from blueelvis and RA489 January 10, 2020 05:53

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2020

Merge remote-tracking branch 'origin/master' into hyperv-external-switch

2955a89

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 13, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2020

Merge remote-tracking branch 'origin/master' into hyperv-external-switch

6c44a47

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2020

tstromberg suggested changes Jan 30, 2020

View reviewed changes

pkg/minikube/registry/drvs/hyperv/vswitch.go Outdated Show resolved Hide resolved

pkg/minikube/registry/drvs/hyperv/vswitch.go Show resolved Hide resolved

pkg/minikube/registry/drvs/hyperv/vswitch.go Outdated Show resolved Hide resolved

laozc added 3 commits February 3, 2020 18:41

Adds comment

e7d2427

Merge remote-tracking branch 'origin/master' into hyperv-external-switch

1a8f871

Move switch creation out of chooseSwitch

fc2cd3c

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2020

tstromberg mentioned this pull request Feb 5, 2020

(meta) Make Windows/Hyper-V a first-class solution #5072

Closed

Merge remote-tracking branch 'origin/master' into hyperv-external-switch

a702ff8

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 6, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2020

Merge remote-tracking branch 'origin/master' into hyperv-external-switch

4ab33dc

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2020

medyagh merged commit 239be7e into kubernetes:master Feb 8, 2020

fmotrifork mentioned this pull request Feb 24, 2020

minikube 1.7.3 fishworks/fish-food#585

Merged

This was referenced Apr 21, 2020

Document --hyperv-use-external-switch flag in hyperv docs #7800

Closed

Describe additional hyperv driver flags #7836

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Hyper-V External Switch #6264

Create Hyper-V External Switch #6264

laozc commented Jan 10, 2020 •

edited

Loading

k8s-ci-robot commented Jan 10, 2020

minikube-bot commented Jan 10, 2020

k8s-ci-robot commented Jan 10, 2020

codecov-io commented Jan 10, 2020 •

edited

Loading

medyagh commented Jan 10, 2020

RA489 commented Jan 13, 2020

minikube-bot commented Jan 13, 2020

laozc commented Jan 13, 2020

minikube-bot commented Jan 17, 2020

minikube-bot commented Jan 17, 2020

minikube-pr-bot commented Jan 17, 2020

minikube-pr-bot commented Jan 22, 2020

minikube-pr-bot commented Feb 3, 2020

medyagh commented Feb 5, 2020

tstromberg commented Feb 5, 2020

minikube-pr-bot commented Feb 6, 2020

tstromberg commented Feb 7, 2020

medyagh commented Feb 8, 2020

minikube-pr-bot commented Feb 8, 2020

medyagh commented Feb 8, 2020

Create Hyper-V External Switch #6264

Create Hyper-V External Switch #6264

Conversation

laozc commented Jan 10, 2020 • edited Loading

k8s-ci-robot commented Jan 10, 2020

minikube-bot commented Jan 10, 2020

k8s-ci-robot commented Jan 10, 2020

codecov-io commented Jan 10, 2020 • edited Loading

Codecov Report

medyagh commented Jan 10, 2020

RA489 commented Jan 13, 2020

minikube-bot commented Jan 13, 2020

laozc commented Jan 13, 2020

minikube-bot commented Jan 17, 2020

minikube-bot commented Jan 17, 2020

minikube-pr-bot commented Jan 17, 2020

minikube-pr-bot commented Jan 22, 2020

minikube-pr-bot commented Feb 3, 2020

medyagh commented Feb 5, 2020

tstromberg commented Feb 5, 2020

minikube-pr-bot commented Feb 6, 2020

tstromberg commented Feb 7, 2020

medyagh commented Feb 8, 2020

minikube-pr-bot commented Feb 8, 2020

medyagh commented Feb 8, 2020

laozc commented Jan 10, 2020 •

edited

Loading

codecov-io commented Jan 10, 2020 •

edited

Loading