Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial for using AWS ECR with registry-creds addon #7245

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

prasadkatti
Copy link
Contributor

fixes #5753

This tutorial describes how one can use the registry-creds addon to configure credentials for AWS ECR in order to be able to pull images onto the minukube cluster.

I have used this PR to learn more about the registry-creds addon. So please take note of that while reviewing. :)

P.S. Is there a linter for markdown? Do I need to add a link to this page on any other (index) page?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @prasadkatti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prasadkatti
To complete the pull request process, please assign priyawadhwa
You can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #7245 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7245      +/-   ##
==========================================
+ Coverage   37.88%   38.04%   +0.16%     
==========================================
  Files         147      147              
  Lines        9065     9087      +22     
==========================================
+ Hits         3434     3457      +23     
+ Misses       5206     5204       -2     
- Partials      425      426       +1     
Impacted Files Coverage Δ
cmd/minikube/cmd/status.go 20.49% <0.00%> (-0.17%) ⬇️
cmd/minikube/cmd/stop.go 0.00% <0.00%> (ø)
pkg/minikube/out/style.go 91.66% <0.00%> (ø)
pkg/minikube/driver/driver.go 64.44% <0.00%> (+2.74%) ⬆️
pkg/minikube/machine/fix.go 40.93% <0.00%> (+4.82%) ⬆️
pkg/minikube/machine/delete.go 47.05% <0.00%> (+7.58%) ⬆️
pkg/minikube/machine/stop.go 32.35% <0.00%> (+10.13%) ⬆️

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing this nice tutorial !

@prasadkatti
Copy link
Contributor Author

@medyagh - The link seems to work for me. Can you please check one more time?

@medyagh
Copy link
Member

medyagh commented Mar 28, 2020

@prasadkatti looks good to me, thank you for adding this. look forward to see more of your contributions

@medyagh medyagh merged commit 45361c4 into kubernetes:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for configuring AWS Elastic Container Registry
5 participants