-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tutorial for using AWS ECR with registry-creds addon #7245
Conversation
Hi @prasadkatti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prasadkatti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #7245 +/- ##
==========================================
+ Coverage 37.88% 38.04% +0.16%
==========================================
Files 147 147
Lines 9065 9087 +22
==========================================
+ Hits 3434 3457 +23
+ Misses 5206 5204 -2
- Partials 425 426 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing this nice tutorial !
@medyagh - The link seems to work for me. Can you please check one more time? |
@prasadkatti looks good to me, thank you for adding this. look forward to see more of your contributions |
fixes #5753
This tutorial describes how one can use the
registry-creds
addon to configure credentials for AWS ECR in order to be able to pull images onto the minukube cluster.I have used this PR to learn more about the
registry-creds
addon. So please take note of that while reviewing. :)P.S. Is there a linter for markdown? Do I need to add a link to this page on any other (index) page?