Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality for "hollow"-node-problem-detector #51

Closed
wants to merge 1 commit into from

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Dec 15, 2016

This PR fixes issue #50
Made the following changes in order to incorporate creation and pushing of a hollow-node-problem-detector image to gcr:

  1. Created a hollow KernelMonitor config with empty rule and condition lists
  2. Converted Dockerfile to a template which can take path to kernelMonitor config as input
  3. Added new targets to Makefile for hollow-node-problem-detector

cc @kubernetes/sig-scalability @wojtek-t @gmarek @Random-Liu


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 15, 2016
@shyamjvs
Copy link
Member Author

Closing this PR since an alternate better solution has been found for issue #50 .

@shyamjvs shyamjvs closed this Dec 16, 2016
@shyamjvs shyamjvs deleted the hollow-node-pd branch December 16, 2016 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants