-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing minor bug in kernel monitor filepath #63
Fixing minor bug in kernel monitor filepath #63
Conversation
Could we fix the config path in this PR, but not bumping up the version? I prefer to bump up the version after the release process is defined. I'll try to write it up soon. :) |
Yes we can do that. But given that the code has already changed, and the version in the Makefile hasn't bumped up, it's kind of urgent to do it as there is a risk for someone to accidentally rewrite the v0.2 image with the new one. Need to prevent such a thing happening. What do you say? If you want, I can change the version just in the makefile and keep the manifest same. |
Cause pushing image to gcr needs special permission. It should be fine to leave it v0.2. I'll try to finish the release process soon, and let's bump up the version then. :) |
c4f4a5b
to
75e45f5
Compare
Sounds good. Changed the PR. |
LGTM. Thanks for the fix! |
@Random-Liu @shyamjvs I prefer to use 0.2.x version number for now. After we solve all the pending P0 prolbems in #58 , we can bump version to 0.3.x and keep in sync with Kubernetes release schedule. This is just a recommendation. :) |
@andyxning As you said, we should:
We should start to do this for newer release. I'm writing a simple doc. |
@andyxning @shyamjvs Hm, I'm really too busy to finish the doc. I'll file an issue and finish the doc after we release 0.3.0. |
Fixes #62 (kernel monitor filepath change)
Ref #60 (bumping version to v0.3)
@Random-Liu Can you PTAL?
This change is