Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing minor bug in kernel monitor filepath #63

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Jan 10, 2017

Fixes #62 (kernel monitor filepath change)
Ref #60 (bumping version to v0.3)

@Random-Liu Can you PTAL?


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2017
@Random-Liu
Copy link
Member

Could we fix the config path in this PR, but not bumping up the version?

I prefer to bump up the version after the release process is defined. I'll try to write it up soon. :)

@shyamjvs
Copy link
Member Author

shyamjvs commented Jan 10, 2017

Yes we can do that. But given that the code has already changed, and the version in the Makefile hasn't bumped up, it's kind of urgent to do it as there is a risk for someone to accidentally rewrite the v0.2 image with the new one. Need to prevent such a thing happening. What do you say? If you want, I can change the version just in the makefile and keep the manifest same.

@Random-Liu
Copy link
Member

Cause pushing image to gcr needs special permission. It should be fine to leave it v0.2.

I'll try to finish the release process soon, and let's bump up the version then. :)
Maybe we'll change the version to v0.3-alpha, v0.3.0 or something else.

@Random-Liu Random-Liu self-assigned this Jan 10, 2017
@Random-Liu Random-Liu self-requested a review January 10, 2017 22:53
@shyamjvs shyamjvs changed the title Bumping npd version to v0.3 and fixing minor bug in kernel monitor filepath Fixing minor bug in kernel monitor filepath Jan 10, 2017
@shyamjvs
Copy link
Member Author

Sounds good. Changed the PR.

@Random-Liu Random-Liu added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2017
@Random-Liu
Copy link
Member

Random-Liu commented Jan 10, 2017

LGTM. Thanks for the fix!

@Random-Liu Random-Liu merged commit d27a480 into kubernetes:master Jan 10, 2017
@andyxning
Copy link
Member

@Random-Liu @shyamjvs I prefer to use 0.2.x version number for now. After we solve all the pending P0 prolbems in #58 , we can bump version to 0.3.x and keep in sync with Kubernetes release schedule.

This is just a recommendation. :)

@Random-Liu
Copy link
Member

Random-Liu commented Jan 11, 2017

@andyxning As you said, we should:

  1. For new release (0.3.0), we should:
    a) Release 0.3.0 before Kubernetes 1.6 code freeze.
    b) Bump up the NPD version in kubernetes NPD e2e test.
    c) Bump up the NPD version in kubernetes cluster after the e2e test stabilizes.
  2. For patch release (this case), we should:
    a) Merge the fix into HEAD.
    b) Cherrypick the fix into 0.2 branch (I didn't create one which I should)
    c) Release 0.2.x image.

We should start to do this for newer release. I'm writing a simple doc.

@Random-Liu
Copy link
Member

Random-Liu commented Jan 11, 2017

@andyxning @shyamjvs Hm, I'm really too busy to finish the doc.
The priority of the release instruction doc is relatively low according to #58, and I think the version control will be pretty much similar with #63 (comment).

I'll file an issue and finish the doc after we release 0.3.0.

@shyamjvs shyamjvs deleted the kernel-monitor-filepath-fix branch January 13, 2017 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants