Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependabot config #811

Closed
wants to merge 4 commits into from
Closed

Add dependabot config #811

wants to merge 4 commits into from

Conversation

MartinForReal
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 14, 2023
@MartinForReal MartinForReal mentioned this pull request Sep 14, 2023
Merged
@MartinForReal
Copy link
Contributor Author

/assign @hakman @vteratipally

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MartinForReal
Once this PR has been reviewed and has the lgtm label, please ask for approval from vteratipally. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MartinForReal
Copy link
Contributor Author

@hakman @vteratipally Any ideas? Thanks!

hakman
hakman suggested changes Sep 21, 2023
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be comfortable with this with some proposed changes, but I would still leave the lgtm label out, so that someone can review and add /lgtm later (anyone in the org can add /lgtm).

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/dependabot.yml Outdated Show resolved Hide resolved
@hakman
Copy link
Member

hakman commented Sep 21, 2023

@vteratipally Any thoughts on this?

MartinForReal and others added 2 commits September 21, 2023 15:51
@MartinForReal @hakman
Apply suggestions from code review
3e55d66 
Co-authored-by: Ciprian Hacman <ciprian@hakman.dev>
@MartinForReal
remove lgtm label
dab099d
hakman
hakman reviewed Sep 21, 2023
View reviewed changes
.github/dependabot.yml Outdated Show resolved Hide resolved
@MartinForReal @hakman
Update .github/dependabot.yml
22c8b8e 
Co-authored-by: Ciprian Hacman <ciprian@hakman.dev>
@vteratipally
Copy link
Collaborator

We follow the kubernetes guidelines, let me confirm with other OWNERS.

@MartinForReal
Copy link
Contributor Author

Any update would be appreciated

@MartinForReal
Copy link
Contributor Author

https://www.thoughtworks.com/en-us/radar/techniques/automatic-merging-of-dependency-update-prs @vteratipally That might be something worthy of trying out.

@MartinForReal MartinForReal mentioned this pull request Dec 22, 2023
Closed
@MartinForReal
Copy link
Contributor Author

@vteratipally @hakman @mmiranda96 Any advice is appreciated

@MartinForReal MartinForReal mentioned this pull request Mar 5, 2024
Closed
@MartinForReal
Copy link
Contributor Author

/retest

@wangzhen127
Copy link
Member

We are updating dependencies weekly now. Do we still need this?

@hakman
Copy link
Member

hakman commented Apr 5, 2024

@wangzhen127 I think we can close this for now.
It was a good idea and debate around it. Thanks @MartinForReal!

@hakman
Copy link
Member

hakman commented Apr 5, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@hakman: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MartinForReal MartinForReal deleted the shafan/dependabot branch April 7, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman requested changes

@sjenning sjenning Awaiting requested review from sjenning

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

Assignees

@hakman hakman

@vteratipally vteratipally

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinForReal @k8s-ci-robot @hakman @vteratipally @wangzhen127