Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce disk/percent_used metric, refs #822 #841

Conversation

AndreMiras
Copy link

@AndreMiras AndreMiras commented Dec 4, 2023

The Stackdriver exports the /guest/disk/percent_used metric to the custom.googleapis.com namespace as the reserved one compute.googleapis.com cannot be used at this stage.

This was tested within GCP Container-Optimized OS with the following:

/mnt/disks/scratch/node-problem-detector \
--enable-k8s-exporter=false \
--config.system-stats-monitor=/etc/node_problem_detector/system-stats-monitor.json \
--config.system-log-monitor=/etc/node_problem_detector/kernel-monitor.json \
--config.custom-plugin-monitor=/etc/node_problem_detector/boot-disk-size-consistency-monitor.json \
--exporter.stackdriver=/etc/node_problem_detector/stackdriver-exporter.json

The /mnt/disks/scratch/ directory was mounted specifically to get execution permissions:

sudo mount -t tmpfs tmpfs /mnt/disks/scratch/

This is what it looks like in GCP Monitoring:
image

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 4, 2023
Copy link

linux-foundation-easycla bot commented Dec 4, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: AndreMiras / name: Andre Miras (09a5d48)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @AndreMiras!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @AndreMiras. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndreMiras
Once this PR has been reviewed and has the lgtm label, please assign vteratipally for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 4, 2023
@AndreMiras AndreMiras force-pushed the feature/disk_utilization_percent_support branch from bdad82d to 1788d76 Compare December 4, 2023 19:05
@AndreMiras AndreMiras changed the title Introduce disk/percent_used metric, fixes #822 Introduce disk/percent_used metric, refs #822 Dec 4, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 4, 2023
The Stackdriver exports the `/guest/disk/percent_used` metric to the
`custom.googleapis.com` namespace as the reserved one
`compute.googleapis.com` cannot be used at this stage.

This was tested within GCP Container-Optimized OS with the following:
```
/mnt/disks/scratch/node-problem-detector \
--enable-k8s-exporter=false \
--config.system-stats-monitor=/etc/node_problem_detector/system-stats-monitor.json \
--config.system-log-monitor=/etc/node_problem_detector/kernel-monitor.json \
--config.custom-plugin-monitor=/etc/node_problem_detector/boot-disk-size-consistency-monitor.json \
--exporter.stackdriver=/etc/node_problem_detector/stackdriver-exporter.json
```
The `/mnt/disks/scratch/` directory was mounted specifically to get execution permissions:
```
sudo mount -t tmpfs tmpfs /mnt/disks/scratch/
```
@AndreMiras AndreMiras force-pushed the feature/disk_utilization_percent_support branch from 1788d76 to 09a5d48 Compare December 4, 2023 19:14
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AndreMiras
Copy link
Author

superseded by #825

@AndreMiras AndreMiras closed this Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants