-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce disk/percent_used metric, refs #822 #841
Introduce disk/percent_used metric, refs #822 #841
Conversation
|
Welcome @AndreMiras! |
Hi @AndreMiras. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndreMiras The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bdad82d
to
1788d76
Compare
The Stackdriver exports the `/guest/disk/percent_used` metric to the `custom.googleapis.com` namespace as the reserved one `compute.googleapis.com` cannot be used at this stage. This was tested within GCP Container-Optimized OS with the following: ``` /mnt/disks/scratch/node-problem-detector \ --enable-k8s-exporter=false \ --config.system-stats-monitor=/etc/node_problem_detector/system-stats-monitor.json \ --config.system-log-monitor=/etc/node_problem_detector/kernel-monitor.json \ --config.custom-plugin-monitor=/etc/node_problem_detector/boot-disk-size-consistency-monitor.json \ --exporter.stackdriver=/etc/node_problem_detector/stackdriver-exporter.json ``` The `/mnt/disks/scratch/` directory was mounted specifically to get execution permissions: ``` sudo mount -t tmpfs tmpfs /mnt/disks/scratch/ ```
1788d76
to
09a5d48
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
superseded by #825 |
The Stackdriver exports the
/guest/disk/percent_used
metric to thecustom.googleapis.com
namespace as the reserved onecompute.googleapis.com
cannot be used at this stage.This was tested within GCP Container-Optimized OS with the following:
The
/mnt/disks/scratch/
directory was mounted specifically to get execution permissions:This is what it looks like in GCP Monitoring: