Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New repository for tracing mutating admission controller #285

Closed
dashpole opened this issue Dec 4, 2018 · 7 comments · Fixed by kubernetes/community#3033
Closed

New repository for tracing mutating admission controller #285

dashpole opened this issue Dec 4, 2018 · 7 comments · Fixed by kubernetes/community#3033
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository

Comments

@dashpole
Copy link
Contributor

dashpole commented Dec 4, 2018

New Repo, Staging Repo, or migrate existing

New repository

Requested name for new repository

mutating-trace-admission-controller

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

piosz, brancz, dashpole

If not a staging repo, who should have write access

Monkeyanator

If a new repo, who should be listed as approvers in OWNERS

piosz, brancz, dashpole

If a new repo, who should be listed in SECURITY_CONTACTS

piosz, brancz, dashpole

What should the repo description be

a mutating admission controller which enables experimental tracing of kubernetes object lifecycle

What SIG and subproject does this fall under in sigs.yaml

This is a new subproject for sig-instrumentation called mutating-trace-admission-controller

Approvals

Meeting notes from 2018-11-29 say "house mutating webhook for adding trace to an object in kubernetes-sigs"

Sig-instrumentation charter specifies that subproject creation is "By SIG Technical Leads"

Additional context for request

See https://github.com/Monkeyanator/mutating-trace-admission-controller for @Monkeyanator's current work on the mutating admission controller for tracing.

/assign @brancz @piosz
for explicit approval

/area github-repo

@k8s-ci-robot k8s-ci-robot added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Dec 4, 2018
@brancz
Copy link
Member

brancz commented Dec 5, 2018

As already discussed in the meeting, this has my approval. This would be our first kubernetes-sigs/ repo, it looks like we will also need to add members owning the project + sig leads to the kubernetes-sigs org in addition to the repo creation (which doesn't seem to be automated in this repo as opposed to org membership).

@dashpole
Copy link
Contributor Author

dashpole commented Dec 5, 2018

@brancz it looks like we need to each open https://github.com/kubernetes/org/issues/new?template=membership.md for that. @Monkeyenator and I have already done so.

@dashpole
Copy link
Contributor Author

friendly ping to @kubernetes/owners, as this is out of SLO

@cblecker
Copy link
Member

@dashpole Sorry, things have been extra busy around KubeCon. Will review this as soon as I have time.

@calebamiles
Copy link
Contributor

/assign

@cblecker
Copy link
Member

Thanks @calebamiles!

@calebamiles
Copy link
Contributor

created. Please update sigs.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants