Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mehabhalodiya to release-engineering group #4797

Closed
wants to merge 1 commit into from
Closed

Add mehabhalodiya to release-engineering group #4797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/kubernetes/sig-release/teams.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,8 @@ teams:
- justaugustus # subproject owner / Chair
- katcosgrove # 1.30 RT Lead
- leonardpahlke # subproject owner (1.26 RT Lead)
- marosset # 1.29 RT Branch Manager Shadow
- marosset # 1.30 RT Branch Manager
- mehabhalodiya # 1.30 RT Branch Manager Shadow
- meganwolf0 # 1.30 Enhancements Shadow
Comment on lines +302 to 304
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mehabhalodiya, Just a heads up – the Prow job (here) is failing due to an unsorted entry.

--- FAIL: TestAllOrgs (0.06s)
config_test.go:268: The team release-team in org Kubernetes has an unsorted list of members.

Sorting the list should get us past the check.

Suggested change
- marosset # 1.30 RT Branch Manager
- mehabhalodiya # 1.30 RT Branch Manager Shadow
- meganwolf0 # 1.30 Enhancements Shadow
- marosset # 1.30 RT Branch Manager
- meganwolf0 # 1.30 Enhancements Shadow
- mehabhalodiya # 1.30 RT Branch Manager Shadow

- mickeyboxell # 1.30 Enhancements Shadow
- pnbrown # 1.30 Enhancements Shadow
Expand Down