-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing bash options to dns/run.sh #1588
Conversation
This is, among others, to properly propagate error status. Ref. kubernetes#1586
011baa5
to
6312eb9
Compare
/lgtm |
@mm4tt: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, prameshj, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like the pull-perf-tests-benchmark-kube-dns is not optional :/ I could make it optional then merge this and then make it back required. However, I'm not sure if it's worth the hassle. Let me try merging this PR with the test failing. |
This is, among others, to properly propagate error status.
Ref. #1586