Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch-list/job: run two replicas per namespace #2281

Merged

Conversation

p0lyn0mial
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Running more than one instance of the watch-list perf test we will put more load on the api-server.
An increased load on the server will allows us for better comparison/understanding scaling characteristic of the streaming API feature.

A single instance (job) of the performance test requires 6 CPUs, 16 RAM. The test runs on an e2-standard-16 machine with 16 CPU, 64 GB.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2023
@p0lyn0mial
Copy link
Contributor Author

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2023
phases:
- namespaceRange:
min: 1
max: 1
basename: watch-list
replicasPerNamespace: 1
replicasPerNamespace: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I think we probably need to first increase the cluster-size to have 2 nodes (I think 2 instances won't fit on a current single node, right?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be fine.

A single instance (job) of the performance test requires 6 CPUs, 16 RAM. The test runs on an e2-standard-16 machine with 16 CPU, 64 GB. It seems we should be able to run the second job.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok - let's see

@wojtek-t
Copy link
Member

wojtek-t commented Jun 5, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 393ccf9 into kubernetes:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants