Probes - boilerplate and first probe #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 2, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
|
/assign @wojtek-t |
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 2, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 2, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
changed the title
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 3, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
wojtek-t
reviewed
Apr 8, 2019
probes/Dockerfile
Outdated
| WORKDIR /go/src/$gopkg | ||
| RUN CGO_ENABLED=0 go build -o /workspace/probes ./cmd | ||
|
|
||
| FROM golang:1.12-alpine |
There was a problem hiding this comment.
Alpine is 3 times smaller: ~100MB vs ~300MB.
wojtek-t
reviewed
Apr 8, 2019
wojtek-t
reviewed
Apr 8, 2019
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 8, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 10, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 10, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 10, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
Probes are simple jobs running inside kubernetes cluster measuring SLIs that could not be measured through other means. Ref. kubernetes/kubernetes#76012
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 16, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 16, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 16, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 16, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 17, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
mm4tt
added a commit
to mm4tt/perf-tests
that referenced
this pull request
Apr 18, 2019
Probes definition can be found in kubernetes#474 The feature is guarded by the enable-probes flag, will be enabling it gradually. Ref. kubernetes/kubernetes#76012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probes are simple jobs running inside kubernetes cluster measuring SLIs that could not be measured through other means.
This PR introduces probes boilerplate and implements two probes for measuring the in-cluster network latency SLI.
Ref. kubernetes/kubernetes#76012