Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling probes via test config override. #506

Closed
wants to merge 1 commit into from

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Apr 18, 2019

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mm4tt
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wojtek-t

If they are not already assigned, you can assign the PR to them by writing /assign @wojtek-t in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member

Given what is happening now in tests, I would prefer to wait until we at least know how many regressions there currently are :-)

@k8s-ci-robot
Copy link
Contributor

@mm4tt: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-perf-tests-clusterloader2 2179a8a link /test pull-perf-tests-clusterloader2
pull-perf-tests-clusterloader2-kubemark 2179a8a link /test pull-perf-tests-clusterloader2-kubemark

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wojtek-t
Copy link
Member

@oxddr - you're working on this now. Can this one now be closed?

@oxddr
Copy link
Contributor

oxddr commented Jul 18, 2019

Equivalent to this code has been merged in some of my recent PRs. I think we can close it.

/close

@k8s-ci-robot
Copy link
Contributor

@oxddr: Closed this PR.

In response to this:

Equivalent to this code has been merged in some of my recent PRs. I think we can close it.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants