Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont error out at end when there is no permission to push to the branch #136

Closed
jessfraz opened this issue Oct 7, 2016 · 12 comments
Closed
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/P1 sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@jessfraz
Copy link
Contributor

jessfraz commented Oct 7, 2016

example:

anago::push_git_objects(): git push origin release-1.4
remote: error: GH006: Protected branch update failed for refs/heads/release-1.4.        
remote: error: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information.        
To git@github.com:kubernetes/kubernetes
 ! [remote rejected] release-1.4 -> release-1.4 (protected branch hook declined)
error: failed to push some refs to 'git@github.com:kubernetes/kubernetes'
@david-mcmahon
Copy link
Contributor

Thanks for the report. What was the original command line?

@jessfraz
Copy link
Contributor Author

jessfraz commented Oct 7, 2016

anago release-1.4 --buildversion=v1.4.1-beta.0.63+90a2226c1bc505 --nomock

@david-mcmahon
Copy link
Contributor

Try running without the --nomock flag to make sure you can get through a run.

I added you to the auth page for the branch to allow pushes.

I'll send a fix for this issue shortly that checks the correct auth.

@jessfraz
Copy link
Contributor Author

jessfraz commented Oct 7, 2016

ya I did and that worked

On Fri, Oct 7, 2016 at 3:43 PM, David McMahon notifications@github.com
wrote:

Try running without the --nomock flag to make sure you can get through a
run.

I added you to the auth page for the branch to allow pushes.

I'll send a fix for this issue shortly that checks the correct auth.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#136 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbArVxvCEvOSWPZL5xhY54iCASQr5ks5qxsslgaJpZM4KRhCi
.

@jessfraz
Copy link
Contributor Author

jessfraz commented Oct 7, 2016

Thanks!!!

On Fri, Oct 7, 2016 at 3:45 PM, Jessica Frazelle jessfraz@google.com
wrote:

ya I did and that worked

On Fri, Oct 7, 2016 at 3:43 PM, David McMahon notifications@github.com
wrote:

Try running without the --nomock flag to make sure you can get through a
run.

I added you to the auth page for the branch to allow pushes.

I'll send a fix for this issue shortly that checks the correct auth.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#136 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbArVxvCEvOSWPZL5xhY54iCASQr5ks5qxsslgaJpZM4KRhCi
.

@david-mcmahon
Copy link
Contributor

@jessfraz you did what? Were you able to complete a non-mock run? You should also have hit the auth issue in mock mode (up until a few minutes ago when I added you to administrators for that branch).

@jessfraz
Copy link
Contributor Author

jessfraz commented Oct 7, 2016

I was able to complete a mock run because it used --dry-run, it all
looked good

On Fri, Oct 7, 2016 at 3:47 PM, David McMahon notifications@github.com
wrote:

@jessfraz https://github.com/jessfraz you did what? Were you able to
complete a non-mock run? You should also have hit the auth issue in mock
mode (up until a few minutes ago when I added you to administrators for
that branch).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#136 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbIPG3NMAJ8aHX-j2ySd8OBj23Pjqks5qxswOgaJpZM4KRhCi
.

@jessfraz
Copy link
Contributor Author

jessfraz commented Oct 7, 2016

Sorry I just meant it worked without the flag --nomock

@david-mcmahon
Copy link
Contributor

Very troubling that --dry-run would behave differently when pushing. That means we have no way to validate auth/perms before we allow the release to happen. I'm going to remove you from the branch again. Can you send me the output of this?

$ git push --dry-run origin release-1.4

@jessfraz
Copy link
Contributor Author

jessfraz commented Oct 7, 2016

$ git push --dry-run origin release-1.4
To git@github.com:kubernetes/kubernetes.git
   6fb175e..4b5e85d  release-1.4 -> release-1.4

@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2017
@david-mcmahon
Copy link
Contributor

Addressing the specific issue of branch auth based on repo admin, that has been resolved.

marpaia pushed a commit to marpaia/release that referenced this issue Feb 21, 2019
Add release_notes_draft.md with proposed new tags
@justaugustus justaugustus added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/P1 sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

5 participants