-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dont error out at end when there is no permission to push to the branch #136
Comments
Thanks for the report. What was the original command line? |
anago release-1.4 --buildversion=v1.4.1-beta.0.63+90a2226c1bc505 --nomock |
Try running without the --nomock flag to make sure you can get through a run. I added you to the auth page for the branch to allow pushes. I'll send a fix for this issue shortly that checks the correct auth. |
ya I did and that worked On Fri, Oct 7, 2016 at 3:43 PM, David McMahon notifications@github.com
|
Thanks!!! On Fri, Oct 7, 2016 at 3:45 PM, Jessica Frazelle jessfraz@google.com
|
@jessfraz you did what? Were you able to complete a non-mock run? You should also have hit the auth issue in mock mode (up until a few minutes ago when I added you to administrators for that branch). |
I was able to complete a mock run because it used --dry-run, it all On Fri, Oct 7, 2016 at 3:47 PM, David McMahon notifications@github.com
|
Sorry I just meant it worked without the flag |
Very troubling that --dry-run would behave differently when pushing. That means we have no way to validate auth/perms before we allow the release to happen. I'm going to remove you from the branch again. Can you send me the output of this?
|
|
Issues go stale after 30d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Addressing the specific issue of branch auth based on repo admin, that has been resolved. |
Add release_notes_draft.md with proposed new tags
example:
The text was updated successfully, but these errors were encountered: